Bug 132392 - [New Multicolumn] ASSERTs in fast/dynamic/continuation-detach-crash.html
Summary: [New Multicolumn] ASSERTs in fast/dynamic/continuation-detach-crash.html
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
Depends on:
Blocks: 131825
  Show dependency treegraph
Reported: 2014-04-30 11:40 PDT by Dave Hyatt
Modified: 2014-04-30 14:28 PDT (History)
5 users (show)

See Also:

Patch (11.82 KB, patch)
2014-04-30 13:46 PDT, Dave Hyatt
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2014-04-30 11:40:34 PDT
The render tree construction is going horribly wrong (nested columns and dynamic spans) in this test case.
Comment 1 Dave Hyatt 2014-04-30 13:46:09 PDT
Created attachment 230517 [details]
Comment 2 WebKit Commit Bot 2014-04-30 13:48:38 PDT
Attachment 230517 [details] did not pass style-queue:

ERROR: Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp:39:  RenderMultiColumnFlowThread::g_shiftingSpanner is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp:304:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderMultiColumnFlowThread.h:153:  g_shiftingSpanner is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 3 in 7 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2014-04-30 14:28:21 PDT
Fixed in r168043.