Bug 132080 - [New Multicolumn] Add support for offsetTop and offsetLeft
Summary: [New Multicolumn] Add support for offsetTop and offsetLeft
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on: 141496
Blocks: 131825
  Show dependency tree / graph
 
Reported: 2014-04-23 14:50 PDT by Dave Hyatt
Modified: 2015-07-24 06:12 PDT (History)
5 users (show)

See Also:

Attachments
Patch (77.33 KB, patch)
2014-04-24 21:16 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (76.38 KB, patch)
2014-04-24 21:19 PDT, Dave Hyatt 		abucur: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2014-04-23 14:50:34 PDT 
fast/multicol/break-after-always-bottom-margin-actual.html fails. Might just be that the test needs to be changed.
Comment 1 Dave Hyatt 2014-04-23 20:41:56 PDT 
This is because offsetTop is not implemented correctly for new columns. Pretty simple to fix.
Comment 2 Dave Hyatt 2014-04-24 21:16:51 PDT 
Created attachment 230134 [details]
Patch
Comment 3 Dave Hyatt 2014-04-24 21:19:31 PDT 
Created attachment 230135 [details]
Patch
Comment 4 Dave Hyatt 2014-04-24 21:26:06 PDT 
(In reply to comment #1)
> This is because offsetTop is not implemented correctly for new columns. Pretty simple to fix.

"Pretty simple to fix." *Grumbles at yesterday me.*
Comment 5 Andrei Bucur 2014-04-24 23:10:54 PDT 
Comment on attachment 230135 [details]
Patch

r=me
Comment 6 Dave Hyatt 2014-04-25 09:22:13 PDT 
Landed in r167808.