Bug 132081 - [New Multicolumn] fast/multicol/hit-test-* layout tests all fail
Summary: [New Multicolumn] fast/multicol/hit-test-* layout tests all fail
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 131825
  Show dependency tree / graph
 
Reported: 2014-04-23 14:51 PDT by Dave Hyatt
Modified: 2014-04-25 13:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (33.32 KB, patch)
2014-04-25 13:02 PDT, Dave Hyatt 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2014-04-23 14:51:38 PDT 
All four of the hit-test-* layout tests fail. Could just be pixel differences, but might be actual bugs here.
Comment 1 Dave Hyatt 2014-04-25 10:38:09 PDT 
I think this boils down to positionForPoint on RenderMultiColumnSet needing to work with logical coordinates instead of treating the point passed in as physical.
Comment 2 Dave Hyatt 2014-04-25 13:02:19 PDT 
Created attachment 230193 [details]
Patch
Comment 3 Dean Jackson 2014-04-25 13:19:41 PDT 
Comment on attachment 230193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230193&action=review

> LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/hit-test-above-or-below.html:31
> +            log ("Character at " + x + ", " + y + " is " + character + " as expected.");
> +        else
> +            log ("FAIL: Character at " + x + ", " + y + " is " + actualCharacter + ". Expected " + character + ".");

Nit: extra space after log
Comment 4 Dave Hyatt 2014-04-25 13:21:20 PDT 
Fixed in r167817.