Bug 131805 - [New Multicolumn] Nested columns not working at all.
Summary: [New Multicolumn] Nested columns not working at all.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords: InRadar
Depends on:
Blocks: 131825
  Show dependency tree / graph
 
Reported: 2014-04-17 13:25 PDT by Dave Hyatt
Modified: 2014-04-24 09:33 PDT (History)
8 users (show)

See Also:

Attachments
Patch (13.12 KB, patch)
2014-04-22 16:39 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (22.75 KB, patch)
2014-04-22 18:04 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (22.67 KB, patch)
2014-04-22 19:28 PDT, Dave Hyatt 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2014-04-17 13:25:29 PDT 
The old multi-column code could at least handle nested columns as an unsplittable unit. The new code should do the same. Right now it is dropping them completely, which will undoubtedly cause regressions in children's books in iBooks.
Comment 1 Radar WebKit Bug Importer 2014-04-17 23:12:56 PDT 
<rdar://problem/16656288>
Comment 2 Dave Hyatt 2014-04-21 13:43:40 PDT 
This is a blocker for turning the new columns on.
Comment 3 Dave Hyatt 2014-04-22 13:22:42 PDT 
This is the challenging one. I wish I knew if iBooks depends on this or not.
Comment 4 Dave Hyatt 2014-04-22 16:39:09 PDT 
Created attachment 229923 [details]
Patch

Work in progress. Everything working now except for transparency. I need to patch bounding box for that to know how to recur.
Comment 5 Dave Hyatt 2014-04-22 18:04:22 PDT 
Created attachment 229935 [details]
Patch
Comment 6 WebKit Commit Bot 2014-04-22 18:06:19 PDT 
Attachment 229935 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderLayer.h:714:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderLayer.cpp:4312:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Dave Hyatt 2014-04-22 19:28:28 PDT 
Created attachment 229945 [details]
Patch
Comment 8 Dave Hyatt 2014-04-23 11:06:10 PDT 
Fixed in r167714.