[New Multicolumn] event.offsetX/offsetY don't work correctly

[Dave Hyatt]

Three form control tests fail because something is still wrong with offsetLeft/Top:

 fast/forms/number/number-spinbutton-in-multi-column.html [ Failure ]
 fast/forms/range/slider-in-multi-column.html [ Failure ]
 fast/forms/select/listbox-in-multi-column.html [ Failure ]

It's all the same bug, so fixing it should make all three test cases pass.

[Dave Hyatt]

This is the cause of fast/events/offsetX-offsetY.html failing as well.

This boils down to mapAbsoluteToLocal not doing the right thing for new columns.

[Dave Hyatt]

Created attachment 230326 [details]
Patch

[WebKit Commit Bot]

Attachment 230326 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderMultiColumnFlowThread.h:111:  The parameter name "transformState" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 230326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230326&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:2646
> +    if (isBox() && o->isOutOfFlowRenderFlowThread()) {

Would be nice to rename "o" at some point.

[Dave Hyatt]

Fix landed in r167910.