Bug 120696 - Unified test infrastructure via the jsc shell
Summary: Unified test infrastructure via the jsc shell
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 120697 120722 120723 120725 120759 120765 120766 120808 120809 120918 120974 120994 120996 121011 121043 121578 122376 122385 122397
Blocks: 112840 122418
  Show dependency tree / graph
 
Reported: 2013-09-04 13:48 PDT by Filip Pizlo
Modified: 2013-10-06 21:06 PDT (History)
8 users (show)

See Also:

Attachments
the ptach (150.89 KB, patch)
2013-10-06 12:01 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (151.15 KB, patch)
2013-10-06 12:04 PDT, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-09-04 13:48:30 PDT 
- Old mozilla tests

- fast/js tests

- fast/js/regress tests

- Benchmarks as regression tests

- Tests that instrument jsc with additional command-line options
Comment 1 Filip Pizlo 2013-09-04 13:49:20 PDT 
This blocks https://bugs.webkit.org/show_bug.cgi?id=112840 because I don't want to proceed with more FTL stuff without a way to test it.
Comment 2 Filip Pizlo 2013-10-06 12:01:45 PDT 
Created attachment 213519 [details]
the ptach
Comment 3 Filip Pizlo 2013-10-06 12:04:12 PDT 
Created attachment 213520 [details]
the patch
Comment 4 Geoffrey Garen 2013-10-06 12:10:35 PDT 
Should we throw sputnik into the mix?
Comment 5 Filip Pizlo 2013-10-06 12:34:31 PDT 
(In reply to comment #4)
> Should we throw sputnik into the mix?

We could but it's hard since Sputnik is in the form of .html files.
Comment 6 Filip Pizlo 2013-10-06 19:14:47 PDT 
Landed in http://trac.webkit.org/changeset/157014
Comment 7 Alexey Proskuryakov 2013-10-06 21:01:40 PDT 
> Should we throw sputnik into the mix?

Or delete it for good?
Comment 8 Filip Pizlo 2013-10-06 21:06:02 PDT 
(In reply to comment #7)
> > Should we throw sputnik into the mix?
> 
> Or delete it for good?

It actually catches things that the other suites don't catch.

So if we did delete it, it would probably only be if we replaced it with test262.  While that might be a good thing to do at some point, it's not critical since test262 is mostly just sputnik + other tests (which we also already have).