Bug 120723 - fast/js/dfg-* tests should wait for the concurrent JIT
Summary: fast/js/dfg-* tests should wait for the concurrent JIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 120696
  Show dependency tree / graph
 
Reported: 2013-09-04 21:44 PDT by Filip Pizlo
Modified: 2015-02-02 09:00 PST (History)
10 users (show)

See Also:

Attachments
part #1 (121.82 KB, patch)
2013-09-04 22:38 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
part #2 (140.28 KB, patch)
2013-09-05 01:04 PDT, Filip Pizlo 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (1.60 MB, application/zip)
2013-09-05 03:20 PDT, Build Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-09-04 21:44:15 PDT 
This was already rubber stamped by Oliver and other people.  I'll land more of this in phases.
Comment 1 Filip Pizlo 2013-09-04 22:38:52 PDT 
Created attachment 210546 [details]
part #1

It turned out big enough that it could use a glance.  The interesting part is the dfgShouldBe() function in js-test-pre and standalone-pre.
Comment 2 Geoffrey Garen 2013-09-04 23:16:12 PDT 
Comment on attachment 210546 [details]
part #1

r=me
Comment 3 Filip Pizlo 2013-09-04 23:29:26 PDT 
(In reply to comment #1)
> Created an attachment (id=210546) [details]
> part #1
> 
> It turned out big enough that it could use a glance.  The interesting part is the dfgShouldBe() function in js-test-pre and standalone-pre.

Landed in http://trac.webkit.org/changeset/155096
Comment 4 Filip Pizlo 2013-09-05 01:04:48 PDT 
Created attachment 210586 [details]
part #2
Comment 5 Build Bot 2013-09-05 03:20:24 PDT 
Comment on attachment 210586 [details]
part #2

Attachment 210586 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1693895

New failing tests:
fast/js/dfg-call-function-hit-watchpoint.html
fast/js/dfg-call-method-hit-watchpoint.html
fast/js/dfg-byte-array-put.html
Comment 6 Build Bot 2013-09-05 03:20:26 PDT 
Created attachment 210596 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.4
Comment 7 Filip Pizlo 2013-09-05 14:27:57 PDT 
(In reply to comment #4)
> Created an attachment (id=210586) [details]
> part #2

Landed in http://trac.webkit.org/changeset/155122