Bug 120759 - Make run-fast-jsc script bash, dash and Darwin's /bin/sh friendly
Summary: Make run-fast-jsc script bash, dash and Darwin's /bin/sh friendly
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Csaba Osztrogonác
Depends on:
Blocks: 120696
  Show dependency treegraph
Reported: 2013-09-05 00:53 PDT by Filip Pizlo
Modified: 2013-09-05 08:11 PDT (History)
11 users (show)

See Also:

Patch (3.03 KB, patch)
2013-09-05 04:24 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-09-05 00:53:53 PDT
The issues are:

- run-fast-jsc is a shell script; it needs a shell that is sufficiently compatible with Darwin /bin/sh.  We should either change the script or make sure that we use the right shell on other platforms.

- I'm not sure if all of the perl-foo is compatible with the perl's on other platforms, though I think I should have fixed this in http://trac.webkit.org/changeset/155101.
Comment 1 Zan Dobersek 2013-09-05 01:50:47 PDT
Most if not all of the Linux builders are running Debian-based systems, meaning /bin/sh links to the dash shell which is not really Bourne-compatible.

/bin/bash should still be available, and the script runs fine when that's used.
Is /bin/bash available on Mac OSs?
Comment 2 Csaba Osztrogonác 2013-09-05 04:18:57 PDT
I have a fix for it.
Comment 3 Csaba Osztrogonác 2013-09-05 04:24:52 PDT
Created attachment 210599 [details]

tested on Linux bash and dash and Darwin's /bin/sh
Comment 4 Csaba Osztrogonác 2013-09-05 04:29:30 PDT
just a note: /bin/sh on Darwin is bash too:

$ /bin/sh --version
GNU bash, version 3.2.48(1)-release (x86_64-apple-darwin11)
Copyright (C) 2007 Free Software Foundation, Inc.
Comment 5 Csaba Osztrogonác 2013-09-05 08:11:01 PDT
Comment on attachment 210599 [details]

Clearing flags on attachment: 210599

Committed r155118: <http://trac.webkit.org/changeset/155118>
Comment 6 Csaba Osztrogonác 2013-09-05 08:11:10 PDT
All reviewed patches have been landed.  Closing bug.