Bug 120766 – Make build.webkit.org report the number of failing run-fast-jsc tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

After https://trac.webkit.org/changeset/155092 master.cfg's
result parser of run-javascript-core-tests should be adjusted.

Now it reports only the old mozilla tests failures. It should 
report the number of failing run-fast-jsc tests too.

[Csaba Osztrogonác]

Created attachment 210603 [details]
unit test for run-javascriptcore-test step

This unit test contains the old and the new output. But it seems that the number if failing fast/js tests is still missing.

[Csaba Osztrogonác]

Created attachment 210614 [details]
Patch

[WebKit Commit Bot]

Attachment 210614 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg', u'Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py', u'Tools/ChangeLog']" exit_code: 1
Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:107:  [RunJavaScriptCoreTestsTest.assertResults] Undefined variable 'RunJavaScriptCoreTests'  [pylint/E0602] [5]
Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:116:  [RunJavaScriptCoreTestsTest.test_no_regressions_old_output] Undefined variable 'SUCCESS'  [pylint/E0602] [5]
Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:122:  [RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output] Undefined variable 'FAILURE'  [pylint/E0602] [5]
Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:127:  [RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output] Undefined variable 'FAILURE'  [pylint/E0602] [5]
Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:137:  [RunJavaScriptCoreTestsTest.test_fast_js_failure_new_output] Undefined variable 'FAILURE'  [pylint/E0602] [5]
Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:147:  [RunJavaScriptCoreTestsTest.test_fast_js_crash_new_output] Undefined variable 'FAILURE'  [pylint/E0602] [5]
Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:157:  [RunJavaScriptCoreTestsTest.test_mozilla_and_fast_js_failure_new_output] Undefined variable 'FAILURE'  [pylint/E0602] [5]
Total errors found: 7 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Csaba Osztrogonác]

(In reply to comment #3)
> Attachment 210614 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg', u'Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py', u'Tools/ChangeLog']" exit_code: 1
> Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:107:  [RunJavaScriptCoreTestsTest.assertResults] Undefined variable 'RunJavaScriptCoreTests'  [pylint/E0602] [5]
> Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:116:  [RunJavaScriptCoreTestsTest.test_no_regressions_old_output] Undefined variable 'SUCCESS'  [pylint/E0602] [5]
> Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:122:  [RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output] Undefined variable 'FAILURE'  [pylint/E0602] [5]
> Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:127:  [RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output] Undefined variable 'FAILURE'  [pylint/E0602] [5]
> Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:137:  [RunJavaScriptCoreTestsTest.test_fast_js_failure_new_output] Undefined variable 'FAILURE'  [pylint/E0602] [5]
> Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:147:  [RunJavaScriptCoreTestsTest.test_fast_js_crash_new_output] Undefined variable 'FAILURE'  [pylint/E0602] [5]
> Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:157:  [RunJavaScriptCoreTestsTest.test_mozilla_and_fast_js_failure_new_output] Undefined variable 'FAILURE'  [pylint/E0602] [5]
> Total errors found: 7 in 3 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

False positive warnings, these variables come from the master.cfg,
which is loaded dinamycally.

[Csaba Osztrogonác]

Comment on attachment 210614 [details]
Patch

Clearing flags on attachment: 210614

Committed r155124: <http://trac.webkit.org/changeset/155124>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

Reopen, because it seems automatic master restart 
on build.webkit.org doesn't work again.

@rniwa, @lforscler or @wms: Could you restart it please? Thanks.

[Lucas Forschler]

restarted at 10:20am, PST

[Csaba Osztrogonác]

Thanks.