This will allow JSC layout tests to be skipped or run using a different mode.
*** Bug 122383 has been marked as a duplicate of this bug. ***
Created attachment 213472 [details] the patch
Landed in http://trac.webkit.org/changeset/156976
Comment on attachment 213472 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=213472&action=review > LayoutTests/js/script-tests/large-expressions.js:3 > +// This test isn't very effective in jsc-stress-tests; it appears that we get a large enough > +// heap on a lot of machines that this just passes. Better to skip for now. > +//@ skip The comment does a good job explaining what is done here. It would be even better if the actual syntax was clearer - "//@ skip" doesn't convey the idea that it's only about jsc-stress-tests, and is thus quite misleading.
(In reply to comment #4) > (From update of attachment 213472 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=213472&action=review > > > LayoutTests/js/script-tests/large-expressions.js:3 > > +// This test isn't very effective in jsc-stress-tests; it appears that we get a large enough > > +// heap on a lot of machines that this just passes. Better to skip for now. > > +//@ skip > > The comment does a good job explaining what is done here. > > It would be even better if the actual syntax was clearer - "//@ skip" doesn't convey the idea that it's only about jsc-stress-tests, and is thus quite misleading. I think it would be great to have a better syntax. Do you have suggestions? Are you thinking of something like: //jsc@ skip