Bug 120994 - run-jsc-stress-tests should be smart enough to call JSRegress "regress/script-tests" rather than "script-tests"
Summary: run-jsc-stress-tests should be smart enough to call JSRegress "regress/script...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 120696 120996
  Show dependency treegraph
 
Reported: 2013-09-07 21:02 PDT by Filip Pizlo
Modified: 2013-09-08 13:12 PDT (History)
7 users (show)

See Also:


Attachments
the patch (2.65 KB, patch)
2013-09-07 21:04 PDT, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-09-07 21:02:11 PDT
run-jsc-stress-tests accepts a list of directories containing tests.  It needs to come up with names for all of them.  Currently it uses the basename of the test directory.  But that means that JSRegress gets called "script-tests", which is unfortunate since any directory in LayoutTests containing .js files will be called "script-tests".  So, we should change run-jsc-stress-tests to use more than just the basename if the basename has the word "tests" in it.  This will cause JSRegress to be called "regress/script-tests".
Comment 1 Filip Pizlo 2013-09-07 21:04:03 PDT
Created attachment 210958 [details]
the patch
Comment 2 Geoffrey Garen 2013-09-08 10:12:18 PDT
Comment on attachment 210958 [details]
the patch

r=me
Comment 3 Filip Pizlo 2013-09-08 13:12:47 PDT
Landed in http://trac.webkit.org/changeset/155305