Bug 220749

Summary: [run-webkit-tests] Support python layout tests
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Chris Gambrell <cgambrell>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, calvaris, cgambrell, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, ryanhaddad, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220876
https://bugs.webkit.org/show_bug.cgi?id=220881
https://bugs.webkit.org/show_bug.cgi?id=220995
https://bugs.webkit.org/show_bug.cgi?id=221776
https://bugs.webkit.org/show_bug.cgi?id=221784
https://bugs.webkit.org/show_bug.cgi?id=222367
https://bugs.webkit.org/show_bug.cgi?id=222418
https://bugs.webkit.org/show_bug.cgi?id=222599
https://bugs.webkit.org/show_bug.cgi?id=222614
https://bugs.webkit.org/show_bug.cgi?id=222618
https://bugs.webkit.org/show_bug.cgi?id=222656
https://bugs.webkit.org/show_bug.cgi?id=222668
https://bugs.webkit.org/show_bug.cgi?id=222935
https://bugs.webkit.org/show_bug.cgi?id=223212
https://bugs.webkit.org/show_bug.cgi?id=223234
https://bugs.webkit.org/show_bug.cgi?id=223475
https://bugs.webkit.org/show_bug.cgi?id=223522
https://bugs.webkit.org/show_bug.cgi?id=223524
https://bugs.webkit.org/show_bug.cgi?id=223541
https://bugs.webkit.org/show_bug.cgi?id=223575
https://bugs.webkit.org/show_bug.cgi?id=223599
https://bugs.webkit.org/show_bug.cgi?id=223602
https://bugs.webkit.org/show_bug.cgi?id=223835
https://bugs.webkit.org/show_bug.cgi?id=223891
https://bugs.webkit.org/show_bug.cgi?id=223905
https://bugs.webkit.org/show_bug.cgi?id=224528
https://bugs.webkit.org/show_bug.cgi?id=224622
https://bugs.webkit.org/show_bug.cgi?id=224702
https://bugs.webkit.org/show_bug.cgi?id=226179
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Jonathan Bedard 2021-01-19 15:07:04 PST
PHP is advertised as deprecated in Big Sur. We need to evaluate converting our PHP tests to something else, most likely Python. The first step of that is allowing apache to actually run Python files.
Comment 1 Radar WebKit Bug Importer 2021-01-19 15:07:15 PST
<rdar://problem/73375271>
Comment 2 Jonathan Bedard 2021-01-19 15:10:44 PST
Created attachment 417918 [details]
Patch
Comment 3 Alexey Proskuryakov 2021-01-19 16:41:10 PST
Comment on attachment 417918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417918&action=review

> Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py:164
> +        for index in range(len(httpd_conf)):

Why does this need to be done dynamically? I would expect all handlers to be defined in httpd.conf.
Comment 4 Alexey Proskuryakov 2021-01-19 16:41:41 PST
Comment on attachment 417918 [details]
Patch

Marking r- because this breaks tests (we have .py files already).
Comment 5 Jonathan Bedard 2021-01-22 09:58:04 PST
Created attachment 418156 [details]
Patch
Comment 6 Jonathan Bedard 2021-01-22 12:23:19 PST
Created attachment 418169 [details]
Patch
Comment 7 Jonathan Bedard 2021-01-22 12:25:01 PST
(In reply to Jonathan Bedard from comment #6)
> Created attachment 418169 [details]
> Patch

This is most of the change, there are still 3 cases we need to resolve, but the specifics of those cases makes me think it would be best to make those changes in separate bugs.
Comment 8 Jonathan Bedard 2021-01-22 19:09:40 PST
Created attachment 418206 [details]
Patch
Comment 9 EWS 2021-01-25 16:33:49 PST
Committed r271867: <https://trac.webkit.org/changeset/271867>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418206 [details].