Description
Jonathan Bedard
2021-01-19 15:07:04 PST
Created attachment 417918 [details]
Patch
Comment on attachment 417918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417918&action=review > Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py:164 > + for index in range(len(httpd_conf)): Why does this need to be done dynamically? I would expect all handlers to be defined in httpd.conf. Comment on attachment 417918 [details]
Patch
Marking r- because this breaks tests (we have .py files already).
Created attachment 418156 [details]
Patch
Created attachment 418169 [details]
Patch
(In reply to Jonathan Bedard from comment #6) > Created attachment 418169 [details] > Patch This is most of the change, there are still 3 cases we need to resolve, but the specifics of those cases makes me think it would be best to make those changes in separate bugs. Created attachment 418206 [details]
Patch
Committed r271867: <https://trac.webkit.org/changeset/271867> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418206 [details]. |