Bug 137424

Summary: Add is<>() / downcast<>() support for RenderObject subclasses
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Layout and RenderingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137056    
Bug Blocks: 137476, 137512, 137545, 137587, 137594, 137622, 137641, 137683, 137696, 137704, 137727, 137733, 137749, 137764, 137766, 137768, 137804, 137824, 137840, 137845    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2014-10-04 14:58:07 PDT
Add is<>() / downcast<>() support for RenderObject subclasses
Attachments
Patch (81.34 KB, patch)
2014-10-04 17:11 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (84.85 KB, patch)
2014-10-04 20:30 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (84.85 KB, patch)
2014-10-06 16:43 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-04 17:11:54 PDT
Created attachment 239287 [details] Patch
Chris Dumez
Comment 2 2014-10-04 20:30:30 PDT
Created attachment 239289 [details] Patch
Benjamin Poulain
Comment 3 2014-10-06 16:00:46 PDT
Comment on attachment 239289 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239289&action=review lgtm. > Source/WebCore/rendering/RenderIterator.h:76 > +// Similar to WTF::is<>() but without the static_assert() making sure > +// the check is necessary. One line. > Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:157 > + if (parentBlock.isRenderMathMLScriptsWrapper()) { No is<RenderMathMLScriptsWrapper>?
Chris Dumez
Comment 4 2014-10-06 16:43:47 PDT
Created attachment 239366 [details] Patch
WebKit Commit Bot
Comment 5 2014-10-06 17:26:29 PDT
Comment on attachment 239366 [details] Patch Clearing flags on attachment: 239366 Committed r174375: <http://trac.webkit.org/changeset/174375>
WebKit Commit Bot
Comment 6 2014-10-06 17:26:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.