Bug 108980

Summary: dfn element should be exposed as AXGroup:AXDefinition
Product: WebKit Reporter: James Craig <jcraig>
Component: AccessibilityAssignee: James Craig <jcraig>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
dfn element test case
none
partial patch
none
patch none

Description James Craig 2013-02-05 14:09:41 PST
dfn element should be exposed as AXGroup:AXDefinition. See attached test case.
Comment 1 James Craig 2013-02-05 14:10:16 PST
Created attachment 186700 [details]
dfn element test case
Comment 2 Radar WebKit Bug Importer 2013-04-15 17:02:11 PDT
<rdar://problem/13658897>
Comment 3 James Craig 2013-04-16 00:07:21 PDT
Created attachment 198269 [details]
partial patch

Not sure why this diff doesn't actually resolve the issue.
Comment 4 James Craig 2013-04-16 12:14:31 PDT
Created attachment 198387 [details]
patch

accessibilityIsIgnored was returning true for the dfn element, updated patch accounts for that and the role.
Comment 5 WebKit Commit Bot 2013-04-16 13:20:01 PDT
The commit-queue encountered the following flaky tests while processing attachment 198387 [details]:

http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org)
svg/animations/smil-leak-elements.svg bug 114280 (authors: fmalita@chromium.org and timothy_horton@apple.com)
svg/animations/smil-leak-dynamically-added-element-instances.svg bug 114281 (authors: fmalita@chromium.org and timothy_horton@apple.com)
fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org)
platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org)
media/video-played-ranges-1.html bug 114675 (authors: annacc@chromium.org, hclam@google.com, jamesr@chromium.org, and vrk@chromium.org)
transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com)
transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org)
transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com)
transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com)
transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org)
transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com)
transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com)
transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com)
transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org)
transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com)
transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com)
transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com)
transitions/flex-transitions.html bug 114195 (author: tony@chromium.org)
transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org)
transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com)
transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com)
transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com)
transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com)
transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org)
transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com)
transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org and simon.fraser@apple.com)
transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org)
transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org)
transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2013-04-16 13:20:57 PDT
Comment on attachment 198387 [details]
patch

Clearing flags on attachment: 198387

Committed r148539: <http://trac.webkit.org/changeset/148539>
Comment 7 WebKit Commit Bot 2013-04-16 13:21:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 James Craig 2013-04-22 12:19:00 PDT
Going to roll some of this back as part of bug 114981.