Bug 89267 - nrwt: restructure manager code
Summary: nrwt: restructure manager code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords: NRWT
Depends on: 89725 92423 92527 92693 92694 92701 92702 92781 92784 92785 92804 92805 92806
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-15 19:34 PDT by Dirk Pranke
Modified: 2012-07-31 18:56 PDT (History)
4 users (show)

See Also:

Attachments
Patch (126.17 KB, patch)
2012-06-15 19:34 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
roll-up patch based of of r121304 + mwb_cleanup + tw_cleanup (127.82 KB, patch)
2012-06-26 19:49 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-06-15 19:34:27 PDT 
nrwt: restructure manager code
Comment 1 Dirk Pranke 2012-06-15 19:34:55 PDT 
Created attachment 147940 [details]
Patch
Comment 2 Dirk Pranke 2012-06-26 19:49:01 PDT 
Created attachment 149668 [details]
roll-up patch based of of r121304 + mwb_cleanup + tw_cleanup

Definitely not for review ... this patch needs a little more work plus all the tests revamped, then broken into more reviewable chunks, of course.
Comment 3 Dirk Pranke 2012-06-26 19:49:42 PDT 
I don't think this technically relies on 76022, but it makes my git branching easier to think that it does ...
Comment 4 Dirk Pranke 2012-07-26 19:44:47 PDT 
Okay, I've done most of the remaining work for this, so more patches will be showing up shortly ...
Comment 5 Dirk Pranke 2012-07-31 18:56:24 PDT 
All patches have been landed (hopefully they'll stick). manager.py is almost a thousand lines smaller compared to the version in r122384 (the last version before I started moving stuff): 1582 lines -> 619 :).