Bug 92694 - nrwt: move the code that identifies the chunk of tests to run into finder
Summary: nrwt: move the code that identifies the chunk of tests to run into finder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on: 92693
Blocks: 89267
  Show dependency treegraph
 
Reported: 2012-07-30 17:16 PDT by Dirk Pranke
Modified: 2012-07-30 18:40 PDT (History)
5 users (show)

See Also:


Attachments
Patch (11.00 KB, patch)
2012-07-30 17:22 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
merge to r124131 (10.83 KB, patch)
2012-07-30 18:14 PDT, Dirk Pranke
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-07-30 17:16:43 PDT
nrwt: move the code that identifies the chunk of tests to run into finder
Comment 1 Dirk Pranke 2012-07-30 17:22:49 PDT
Created attachment 155405 [details]
Patch
Comment 2 Dirk Pranke 2012-07-30 18:14:25 PDT
Created attachment 155412 [details]
merge to r124131
Comment 3 Ryosuke Niwa 2012-07-30 18:23:59 PDT
Comment on attachment 155412 [details]
merge to r124131

View in context: https://bugs.webkit.org/attachment.cgi?id=155412&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:399
> +        self._tests = set(self._test_files_list)

Why do we need to set this variable?
Comment 4 Dirk Pranke 2012-07-30 18:26:29 PDT
(In reply to comment #3)
> (From update of attachment 155412 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=155412&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:399
> > +        self._tests = set(self._test_files_list)
> 
> Why do we need to set this variable?

the manager code needs the tests both as a set and a list (order preserved), so we have to keep them in sync. This is really confusing; a later patch cleans this up.
Comment 5 Dirk Pranke 2012-07-30 18:40:44 PDT
Committed r124139: <http://trac.webkit.org/changeset/124139>