RESOLVED FIXED Bug 92694
nrwt: move the code that identifies the chunk of tests to run into finder 
https://bugs.webkit.org/show_bug.cgi?id=92694
Summary nrwt: move the code that identifies the chunk of tests to run into finder
Dirk Pranke
Reported 2012-07-30 17:16:43 PDT
nrwt: move the code that identifies the chunk of tests to run into finder
Attachments
Patch (11.00 KB, patch)
2012-07-30 17:22 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
merge to r124131 (10.83 KB, patch)
2012-07-30 18:14 PDT, Dirk Pranke 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-07-30 17:22:49 PDT
Created attachment 155405 [details] Patch
Dirk Pranke
Comment 2 2012-07-30 18:14:25 PDT
Created attachment 155412 [details] merge to r124131
Ryosuke Niwa
Comment 3 2012-07-30 18:23:59 PDT
Comment on attachment 155412 [details] merge to r124131 View in context: https://bugs.webkit.org/attachment.cgi?id=155412&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:399 > + self._tests = set(self._test_files_list) Why do we need to set this variable?
Dirk Pranke
Comment 4 2012-07-30 18:26:29 PDT
(In reply to comment #3) > (From update of attachment 155412 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=155412&action=review > > > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:399 > > + self._tests = set(self._test_files_list) > > Why do we need to set this variable? the manager code needs the tests both as a set and a list (order preserved), so we have to keep them in sync. This is really confusing; a later patch cleans this up.
Dirk Pranke
Comment 5 2012-07-30 18:40:44 PDT
Committed r124139: <http://trac.webkit.org/changeset/124139>
Note You need to log in before you can comment on or make changes to this bug.