Bug 92784 - nrwt: clean up TestInputs in preparation for cleaning up sharding
Summary: nrwt: clean up TestInputs in preparation for cleaning up sharding
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on: 92781
Blocks: 89267 92785
  Show dependency tree / graph
 
Reported: 2012-07-31 12:30 PDT by Dirk Pranke
Modified: 2012-07-31 13:49 PDT (History)
6 users (show)

See Also:

Attachments
Patch (21.21 KB, patch)
2012-07-31 12:33 PDT, Dirk Pranke 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-07-31 12:30:29 PDT 
nrwt: clean up TestInputs in preparation for cleaning up sharding
Comment 1 Dirk Pranke 2012-07-31 12:33:22 PDT 
Created attachment 155605 [details]
Patch
Comment 2 Ryosuke Niwa 2012-07-31 12:52:47 PDT 
Comment on attachment 155605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155605&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_input.py:40
> +        self.timeout = timeout  # in msecs; should rename this for consistency

Nit: ms is a SI unit whereas msecs isn't.
Comment 3 Dirk Pranke 2012-07-31 13:02:50 PDT 
(In reply to comment #2)
> (From update of attachment 155605 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=155605&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/models/test_input.py:40
> > +        self.timeout = timeout  # in msecs; should rename this for consistency
> 
> Nit: ms is a SI unit whereas msecs isn't.

good point.
Comment 4 Dirk Pranke 2012-07-31 13:49:06 PDT 
Committed r124246: <http://trac.webkit.org/changeset/124246>