Bug 92781 - nrwt: clean up prepare_lists_and_print_output, run, set_up_run a bit
Summary: nrwt: clean up prepare_lists_and_print_output, run, set_up_run a bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords: NRWT
Depends on: 92702
Blocks: 89267 92784
  Show dependency tree / graph
 
Reported: 2012-07-31 12:03 PDT by Dirk Pranke
Modified: 2012-07-31 12:43 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.69 KB, patch)
2012-07-31 12:03 PDT, Dirk Pranke 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-07-31 12:03:05 PDT 
nrwt: clean up prepare_lists_and_print_output, run, set_up_run a bit
Comment 1 Dirk Pranke 2012-07-31 12:03:52 PDT 
Created attachment 155602 [details]
Patch
Comment 2 Ryosuke Niwa 2012-07-31 12:22:08 PDT 
Comment on attachment 155602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155602&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:695
> +        if not self._test_names:

Shouldn't we checking this after subtracting tests_to_skip?
Comment 3 Dirk Pranke 2012-07-31 12:43:05 PDT 
Committed r124240: <http://trac.webkit.org/changeset/124240>