JavaInstance should be a pure interface

[Steve Block]

The Java bridge code in WebCore/bridge/jni uses JavaInstance to represent a Java object which can be injected into JavaScript. The binding to JavaScript is done via NPAPI so objects of type JavaInstance are manipulated via JavaNPObject.

The implementation of JavaInstance is a simple wrapper around a JNI jobject. To allow implementations flexibility in how the binding to a Java object is achieved, JavaInstance should be an interface. The current JavaInstance implementation would be moved to a new JavaInstanceJobject class which implements this interface.

[Steve Block]

Created attachment 88047 [details]
Patch 1

[Andrei Popescu]

> Source/WebCore/bridge/jni/v8/JavaInstanceJobjectV8.cpp:45
> +    m_class = 0;

Can we use an initialization list instead?

> Source/WebCore/bridge/jni/v8/JavaInstanceJobjectV8.cpp:51
> +    delete m_class;

Use an OwnPtr?

[Steve Block]

> Can we use an initialization list instead?
Done

> Use an OwnPtr?
Done

[Steve Block]

Created attachment 88249 [details]
Patch 2

[Andrei Popescu]

LGTM

[Dimitri Glazkov (Google)]

Comment on attachment 88249 [details]
Patch 2

rs=me.

[Steve Block]

Committed r82950: <http://trac.webkit.org/changeset/82950>