RESOLVED FIXED 55384
JObjectWrapper should be moved to its own file 
https://bugs.webkit.org/show_bug.cgi?id=55384
Summary JObjectWrapper should be moved to its own file
Steve Block
Reported 2011-02-28 08:55:16 PST
Currently, JObjectWrapper lives in JavaInstance.cpp/h. It should be moved to its own file. This will simplify the refactoring of JavaInstance in Bug 55383. It should probably also be renamed to JobjectWrapper, as it is a wrapper around a jobject.
Attachments
Patch (11.07 KB, patch)
2011-03-01 15:17 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2011-03-01 15:17:53 PST
Created attachment 84305 [details] Patch
Jeremy Orlow
Comment 2 2011-03-01 16:18:25 PST
Comment on attachment 84305 [details] Patch Is Jobject (vs JObject) actually correct? r=me
WebKit Commit Bot
Comment 3 2011-03-01 21:28:12 PST
Comment on attachment 84305 [details] Patch Rejecting attachment 84305 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'build'..." exit_code: 2 Last 500 characters of output: ork/Resources/pbxcp -exclude .DS_Store -exclude CVS -exclude .svn -strip-debug-symbols -resolve-src-symlinks /mnt/git/webkit-commit-queue/WebKitBuild/Release/WebProcess.app /mnt/git/webkit-commit-queue/WebKitBuild/Release/WebKit2.framework ** BUILD FAILED ** The following build commands failed: WebKit2: PhaseScriptExecution "Check For Inappropriate Files In Framework" /mnt/git/webkit-commit-queue/WebKitBuild/WebKit2.build/Release/WebKit2.build/Script-5DF408D1131DDBEC00130071.sh (1 failure) Full output: http://queues.webkit.org/results/8074778
Steve Block
Comment 4 2011-03-02 01:21:08 PST
Comment on attachment 84305 [details] Patch WebKit2 build break unrelated to this change, trying again.
Eric Seidel (no email)
Comment 5 2011-03-02 01:23:27 PST
Odd. I'm not sure how that could happen.
WebKit Commit Bot
Comment 6 2011-03-02 01:50:00 PST
Comment on attachment 84305 [details] Patch Clearing flags on attachment: 84305 Committed r80103: <http://trac.webkit.org/changeset/80103>
WebKit Commit Bot
Comment 7 2011-03-02 01:50:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.