Chromium gypi file should include Java bridge files from WebCore/bridge

[Steve Block]

Chromium gypi file should include Java bridge files from WebCore/bridge

[Steve Block]

Created attachment 84076 [details]
Patch

[Steve Block]

Comment on attachment 84076 [details]
Patch

Do not land until dependencies have landed.

[WebKit Review Bot]

Attachment 84076 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8071358

[Dimitri Glazkov (Google)]

Comment on attachment 84076 [details]
Patch

Chromium is barfing. Can haz exludes?

[Steve Block]

This should build fine once the dependencies are in. Will run it by the commit queue again once that's the case.

[Adam Barth]

Are we planning to use these files in all configurations of Chromium?  Perhaps we should exclude them conditionally.

[WebKit Review Bot]

Attachment 84076 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8071402

[Steve Block]

Created attachment 84210 [details]
Patch

[WebKit Review Bot]

Attachment 84210 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8072627

[Steve Block]

Comment on attachment 84210 [details]
Patch

The build fails due to the JAVA_BRIDGE guards being incomplete. Filed Bug 55459.

> Are we planning to use these files in all configurations of Chromium?
The gypi file should list all WebCore files, so I think it makes sense to add these, once they build OK.

[Steve Block]

Created attachment 84224 [details]
Patch

[Jeremy Orlow]

Comment on attachment 84224 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 84224 [details]
Patch

Rejecting attachment 84224 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 1

Last 500 characters of output:
rks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 361, in _call_chain
    result = func(*args)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_http.py", line 756, in https_open
    return self.do_open(conn_factory, req)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_http.py", line 706, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://queues.webkit.org/results/8071723

[Steve Block]

Looks like commit queue flakiness.

Will land manually.

[Steve Block]

Committed r80045: <http://trac.webkit.org/changeset/80045>

[Eric Seidel (no email)]

(In reply to comment #14)
> Looks like commit queue flakiness.
> 
> Will land manually.

Looks like our AppEngine instance went down for a second. :)  We dont' handle that case very well.