Bug 56009 - JavaNPObject should not use JNI directly
Summary: JavaNPObject should not use JNI directly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 55383
  Show dependency tree / graph
 
Reported: 2011-03-09 04:15 PST by Steve Block
Modified: 2011-03-09 11:14 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.43 KB, patch)
2011-03-09 05:40 PST, Steve Block 		jorlow: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2011-03-09 04:15:55 PST 
JavaNPObject should not know about JNI. Instead it should make calls to Java through JavaInstance, which will in turn use JNI to access Java.

This will allow us to factor out a JavaInstance interface which is independent of JNI. See Bug 55383.
Comment 1 Steve Block 2011-03-09 05:40:44 PST 
Created attachment 85165 [details]
Patch
Comment 2 Andrei Popescu 2011-03-09 09:52:38 PST 
LGTM
Comment 3 Jeremy Orlow 2011-03-09 10:01:21 PST 
Comment on attachment 85165 [details]
Patch

r(ubber stamp)=me
Comment 4 Steve Block 2011-03-09 11:14:34 PST 
Committed r80653: <http://trac.webkit.org/changeset/80653>