RESOLVED FIXED 56197
JNIType is not specific to JNI so should be renamed 
https://bugs.webkit.org/show_bug.cgi?id=56197
Summary JNIType is not specific to JNI so should be renamed
Steve Block
Reported 2011-03-11 08:55:11 PST
JNIType is not specific to JNI so should be renamed
Attachments
Patch (63.29 KB, patch)
2011-03-11 09:07 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Patch (63.06 KB, patch)
2011-03-23 17:57 PDT, Steve Block 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2011-03-11 08:58:01 PST
This enum describes a general Java type, so should be renamed to JavaType and moved out of JNIUtility.h. This is part of making JavaInstance a clean interface that is not dependent upon JNI. See Bug 55383.
Steve Block
Comment 2 2011-03-11 09:07:52 PST
Created attachment 85479 [details] Patch
Jeremy Orlow
Comment 3 2011-03-11 09:39:38 PST
Comment on attachment 85479 [details] Patch r=me
Steve Block
Comment 4 2011-03-23 17:57:40 PDT
Created attachment 86728 [details] Patch
Steve Block
Comment 5 2011-03-23 17:58:21 PDT
Comment on attachment 86728 [details] Patch Rebased only. Checking try-bots. No review required.
Steve Block
Comment 6 2011-03-24 02:49:26 PDT
Comment on attachment 86728 [details] Patch Rebased only. Checking try-bots. No review required.
WebKit Commit Bot
Comment 7 2011-03-24 03:46:59 PDT
Comment on attachment 86728 [details] Patch Rejecting attachment 86728 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 1 Last 500 characters of output: tTests/platform/gtk/fast/block/lineboxcontain/inline-box-vertical-expected.checksum A LayoutTests/platform/gtk/fast/block/lineboxcontain/block-font-expected.txt A LayoutTests/platform/gtk/fast/block/lineboxcontain/inline-replaced-expected.png A LayoutTests/editing/selection/fake-drag-expected.txt M LayoutTests/ChangeLog r81858 = e75e7eb10efcc9c1b1b3dd52461ad2a4930057ee (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/8233466
Steve Block
Comment 8 2011-03-24 04:20:01 PDT
Committed r81860: <http://trac.webkit.org/changeset/81860>
WebKit Review Bot
Comment 9 2011-03-24 07:19:31 PDT
http://trac.webkit.org/changeset/81860 might have broken Windows XP Debug (Tests) The following tests are not passing: http/tests/inspector/network/network-redirect.html
Note You need to log in before you can comment on or make changes to this bug.