Bug 55967 - NPAPI - jvalue conversion should not be in JavaInstance
Summary: NPAPI - jvalue conversion should not be in JavaInstance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 55966
Blocks: 55383 55765
  Show dependency tree / graph
 
Reported: 2011-03-08 14:20 PST by Steve Block
Modified: 2011-03-09 10:17 PST (History)
3 users (show)

See Also:

Attachments
Patch (5.97 KB, patch)
2011-03-09 03:47 PST, Steve Block 		jorlow: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2011-03-08 14:20:29 PST 
The logic to convert between NPAPI and jvalue values does not belong in JavaInstance, as this class logically represents a Java object and should not know about NPAPI types. Instead, this logic should be moved out of JavaInstance (and into JavaNPObject in the case of V8).

This will also allow all implementors of the new JavaInstance interface to share this logic. See Bug 55383.
Comment 1 Steve Block 2011-03-09 03:47:06 PST 
Created attachment 85153 [details]
Patch
Comment 2 Jeremy Orlow 2011-03-09 09:59:50 PST 
Comment on attachment 85153 [details]
Patch

r=me
Comment 3 Andrei Popescu 2011-03-09 10:05:50 PST 
LGTM
Comment 4 Steve Block 2011-03-09 10:17:53 PST 
Committed r80647: <http://trac.webkit.org/changeset/80647>