Update the format used by ProcessThrottler in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form: <object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values> So, for example: [PID: 0] 0x1145ce5e8 - ProcessThrottler::invalidateAllActivities() BEGIN becomes: 0x1145ce5e8 - [PID: 0] ProcessThrottler::invalidateAllActivities: BEGIN
<rdar://problem/58265958>
Created attachment 386594 [details] Patch
Comment on attachment 386594 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386594&action=review > Source/WebKit/UIProcess/ProcessThrottler.h:86 > + PROCESSTHROTTLER_ACTIVITY_RELEASE_LOG("invalidate: Ending %{public}s activity / '%{public}s'", Alternatively you could move these implementations to the cpp file and not have new macros named PROCESSTHROTTLER_ACTIVITY_RELEASE_LOG
(In reply to Alex Christensen from comment #3) > Alternatively you could move these implementations to the cpp file and not > have new macros named PROCESSTHROTTLER_ACTIVITY_RELEASE_LOG Regardless of where the implementation is, I'd still have PROCESSTHROTTLER_ACTIVITY_RELEASE_LOG, since the point of that macro is to identify that the method is from ProcessThrottler::Activity.
The commit-queue encountered the following flaky tests while processing attachment 386594 [details]: highlight/highlight-world-leak.html bug 205643 (author: megan_gardner@apple.com) The commit-queue is continuing to process your patch.
Comment on attachment 386594 [details] Patch Clearing flags on attachment: 386594 Committed r253980: <https://trac.webkit.org/changeset/253980>
All reviewed patches have been landed. Closing bug.