Bug 205679 - Reformat ProcessThrottler logging
Summary: Reformat ProcessThrottler logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-01 20:13 PST by Keith Rollin
Modified: 2020-01-08 20:29 PST (History)
4 users (show)

See Also:


Attachments
Patch (10.90 KB, patch)
2020-01-01 20:15 PST, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-01-01 20:13:13 PST
Update the format used by ProcessThrottler in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form:

    <object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>

So, for example:

    [PID: 0] 0x1145ce5e8 - ProcessThrottler::invalidateAllActivities() BEGIN

becomes:

    0x1145ce5e8 - [PID: 0] ProcessThrottler::invalidateAllActivities: BEGIN
Comment 1 Radar WebKit Bug Importer 2020-01-01 20:13:23 PST
<rdar://problem/58265958>
Comment 2 Keith Rollin 2020-01-01 20:15:31 PST
Created attachment 386594 [details]
Patch
Comment 3 Alex Christensen 2020-01-02 10:53:13 PST
Comment on attachment 386594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386594&action=review

> Source/WebKit/UIProcess/ProcessThrottler.h:86
> +            PROCESSTHROTTLER_ACTIVITY_RELEASE_LOG("invalidate: Ending %{public}s activity / '%{public}s'",

Alternatively you could move these implementations to the cpp file and not have new macros named PROCESSTHROTTLER_ACTIVITY_RELEASE_LOG
Comment 4 Keith Rollin 2020-01-02 12:38:40 PST
(In reply to Alex Christensen from comment #3)
> Alternatively you could move these implementations to the cpp file and not
> have new macros named PROCESSTHROTTLER_ACTIVITY_RELEASE_LOG

Regardless of where the implementation is, I'd still have PROCESSTHROTTLER_ACTIVITY_RELEASE_LOG, since the point of that macro is to identify that the method is from ProcessThrottler::Activity.
Comment 5 WebKit Commit Bot 2020-01-02 13:24:08 PST
The commit-queue encountered the following flaky tests while processing attachment 386594 [details]:

highlight/highlight-world-leak.html bug 205643 (author: megan_gardner@apple.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-01-02 13:25:02 PST
Comment on attachment 386594 [details]
Patch

Clearing flags on attachment: 386594

Committed r253980: <https://trac.webkit.org/changeset/253980>
Comment 7 WebKit Commit Bot 2020-01-02 13:25:03 PST
All reviewed patches have been landed.  Closing bug.