Bug 205984 - Reformat FrameView logging
Summary: Reformat FrameView logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-08 20:29 PST by Keith Rollin
Modified: 2020-01-09 10:02 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.21 KB, patch)
2020-01-08 20:30 PST, Keith Rollin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-01-08 20:29:05 PST 
Update the format used by FrameView in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form:

    <object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>

So, for example:

    0x4a1cf8010 - FrameView::fireLayoutRelatedMilestonesIfNeeded() - firing first visually non-empty layout milestone on the main frame

becomes:

    0x561be8010 - [frame=0x55d47e000, main=1] FrameView::fireLayoutRelatedMilestonesIfNeeded: Firing first visually non-empty layout milestone on the main frame
Comment 1 Radar WebKit Bug Importer 2020-01-08 20:29:13 PST 
<rdar://problem/58431722>
Comment 2 Keith Rollin 2020-01-08 20:30:57 PST 
Created attachment 387184 [details]
Patch
Comment 3 Brent Fulgham 2020-01-09 09:01:31 PST 
Comment on attachment 387184 [details]
Patch

r=me. The Mac-wk2 failures seem totally unrelated (and perhaps an error in the EWS system itself).
Comment 4 WebKit Commit Bot 2020-01-09 10:02:25 PST 
Comment on attachment 387184 [details]
Patch

Clearing flags on attachment: 387184

Committed r254267: <https://trac.webkit.org/changeset/254267>
Comment 5 WebKit Commit Bot 2020-01-09 10:02:27 PST 
All reviewed patches have been landed.  Closing bug.