WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 205984
Reformat FrameView logging
https://bugs.webkit.org/show_bug.cgi?id=205984
Summary
Reformat FrameView logging
Keith Rollin
Reported
2020-01-08 20:29:05 PST
Update the format used by FrameView in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form: <object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values> So, for example: 0x4a1cf8010 - FrameView::fireLayoutRelatedMilestonesIfNeeded() - firing first visually non-empty layout milestone on the main frame becomes: 0x561be8010 - [frame=0x55d47e000, main=1] FrameView::fireLayoutRelatedMilestonesIfNeeded: Firing first visually non-empty layout milestone on the main frame
Attachments
Patch
(3.21 KB, patch)
2020-01-08 20:30 PST
,
Keith Rollin
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2020-01-08 20:29:13 PST
<
rdar://problem/58431722
>
Keith Rollin
Comment 2
2020-01-08 20:30:57 PST
Created
attachment 387184
[details]
Patch
Brent Fulgham
Comment 3
2020-01-09 09:01:31 PST
Comment on
attachment 387184
[details]
Patch r=me. The Mac-wk2 failures seem totally unrelated (and perhaps an error in the EWS system itself).
WebKit Commit Bot
Comment 4
2020-01-09 10:02:25 PST
Comment on
attachment 387184
[details]
Patch Clearing flags on attachment: 387184 Committed
r254267
: <
https://trac.webkit.org/changeset/254267
>
WebKit Commit Bot
Comment 5
2020-01-09 10:02:27 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug