WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 205884
Reformat FrameLoader logging
https://bugs.webkit.org/show_bug.cgi?id=205884
Summary
Reformat FrameLoader logging
Keith Rollin
Reported
2020-01-07 14:02:29 PST
Update the format used by FrameLoader in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form: <object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values> So, for example: 0x4aa2df000 - FrameLoader::allAllLoaders: Clearing provisional document loader (frame = 0x4a8ad3550, main = 0 m_provisionalDocumentLoader=0x0) becomes: 0x465fb61a0 - [frame=0x465c98a20, main=0] FrameLoader::stopAllLoaders: Clearing provisional document loader (m_provisionalDocumentLoader=0x0)
Attachments
Patch
(26.74 KB, patch)
2020-01-07 14:07 PST
,
Keith Rollin
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2020-01-07 14:02:43 PST
<
rdar://problem/58387123
>
Keith Rollin
Comment 2
2020-01-07 14:07:12 PST
Created
attachment 387030
[details]
Patch
Brent Fulgham
Comment 3
2020-01-07 15:09:10 PST
Comment on
attachment 387030
[details]
Patch LGTM. r=me
WebKit Commit Bot
Comment 4
2020-01-07 17:31:27 PST
Comment on
attachment 387030
[details]
Patch Clearing flags on attachment: 387030 Committed
r254179
: <
https://trac.webkit.org/changeset/254179
>
WebKit Commit Bot
Comment 5
2020-01-07 17:31:29 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug