Bug 205884 - Reformat FrameLoader logging
Summary: Reformat FrameLoader logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-07 14:02 PST by Keith Rollin
Modified: 2020-01-07 17:31 PST (History)
7 users (show)

See Also:

Attachments
Patch (26.74 KB, patch)
2020-01-07 14:07 PST, Keith Rollin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-01-07 14:02:29 PST 
Update the format used by FrameLoader in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form:

    <object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>

So, for example:

    0x4aa2df000 - FrameLoader::allAllLoaders: Clearing provisional document loader (frame = 0x4a8ad3550, main = 0 m_provisionalDocumentLoader=0x0)

becomes:

    0x465fb61a0 - [frame=0x465c98a20, main=0] FrameLoader::stopAllLoaders: Clearing provisional document loader (m_provisionalDocumentLoader=0x0)
Comment 1 Radar WebKit Bug Importer 2020-01-07 14:02:43 PST 
<rdar://problem/58387123>
Comment 2 Keith Rollin 2020-01-07 14:07:12 PST 
Created attachment 387030 [details]
Patch
Comment 3 Brent Fulgham 2020-01-07 15:09:10 PST 
Comment on attachment 387030 [details]
Patch

LGTM. r=me
Comment 4 WebKit Commit Bot 2020-01-07 17:31:27 PST 
Comment on attachment 387030 [details]
Patch

Clearing flags on attachment: 387030

Committed r254179: <https://trac.webkit.org/changeset/254179>
Comment 5 WebKit Commit Bot 2020-01-07 17:31:29 PST 
All reviewed patches have been landed.  Closing bug.