Bug 205869 – Reformat WebFrameLoaderClient logging

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Keith Rollin]

Update the format used by WebFrameLoaderClient in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form:

    <object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>

So, for example:

    0x4a1d7c310 - WebFrameLoaderClient::dispatchDidReachLayoutMilestone: dispatching didCompletePageTransition, page = 0x7f83ba009208

becomes:

    0x4a1d7c310 - [webFrame=0x7ff703f03b68, webFrameID=3, webPage=0x7ff704831808, webPageID=15] WebFrameLoaderClient::dispatchDidReachLayoutMilestone: dispatching didCompletePageTransition

[Radar WebKit Bug Importer]

<rdar://problem/58379240>

[Keith Rollin]

Created attachment 386992 [details]
Patch

[Brent Fulgham]

Comment on attachment 386992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386992&action=review

r=me

> Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:339
> +        WEBFRAMELOADERCLIENT_RELEASE_LOG_FAULT(Loading, "dispatchDidReceiveServerRedirectForProvisionalLoad: Called with no provisional DocumentLoader (frameState=%i, stateForDebugging=%i)", m_frame->coreFrame()->loader().state(), m_frame->coreFrame()->loader().stateMachine().stateForDebugging());

This seems a little wordy, but I can't think of a better naming scheme.

[WebKit Commit Bot]

Comment on attachment 386992 [details]
Patch

Clearing flags on attachment: 386992

Committed r254147: <https://trac.webkit.org/changeset/254147>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.