Bug 205869 - Reformat WebFrameLoaderClient logging
Summary: Reformat WebFrameLoaderClient logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-07 10:35 PST by Keith Rollin
Modified: 2020-01-07 12:39 PST (History)
5 users (show)

See Also:

Attachments
Patch (8.72 KB, patch)
2020-01-07 10:38 PST, Keith Rollin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-01-07 10:35:54 PST 
Update the format used by WebFrameLoaderClient in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form:

    <object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>

So, for example:

    0x4a1d7c310 - WebFrameLoaderClient::dispatchDidReachLayoutMilestone: dispatching didCompletePageTransition, page = 0x7f83ba009208

becomes:

    0x4a1d7c310 - [webFrame=0x7ff703f03b68, webFrameID=3, webPage=0x7ff704831808, webPageID=15] WebFrameLoaderClient::dispatchDidReachLayoutMilestone: dispatching didCompletePageTransition
Comment 1 Radar WebKit Bug Importer 2020-01-07 10:36:09 PST 
<rdar://problem/58379240>
Comment 2 Keith Rollin 2020-01-07 10:38:19 PST 
Created attachment 386992 [details]
Patch
Comment 3 Brent Fulgham 2020-01-07 11:54:28 PST 
Comment on attachment 386992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386992&action=review

r=me

> Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:339
> +        WEBFRAMELOADERCLIENT_RELEASE_LOG_FAULT(Loading, "dispatchDidReceiveServerRedirectForProvisionalLoad: Called with no provisional DocumentLoader (frameState=%i, stateForDebugging=%i)", m_frame->coreFrame()->loader().state(), m_frame->coreFrame()->loader().stateMachine().stateForDebugging());

This seems a little wordy, but I can't think of a better naming scheme.
Comment 4 WebKit Commit Bot 2020-01-07 12:39:00 PST 
Comment on attachment 386992 [details]
Patch

Clearing flags on attachment: 386992

Committed r254147: <https://trac.webkit.org/changeset/254147>
Comment 5 WebKit Commit Bot 2020-01-07 12:39:02 PST 
All reviewed patches have been landed.  Closing bug.