Bug 205683 - Reformat WebProcessCache logging
Summary: Reformat WebProcessCache logging
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Keywords: InRadar
Depends on:
Reported: 2020-01-02 00:28 PST by Keith Rollin
Modified: 2020-01-02 13:43 PST (History)
4 users (show)

See Also:

Patch (12.99 KB, patch)
2020-01-02 00:30 PST, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-01-02 00:28:07 PST
Update the format used by WebProcessCache in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form:

    <object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>

So, for example:

    0x1145ed208 - WebProcessCache::canCacheProcess(): Not caching process 83671 because it does not have an associated registrable domain


    0x1145ed208 - [PID=83671] WebProcessCache::canCacheProcess: Not caching process because it does not have an associated registrable domain
Comment 1 Radar WebKit Bug Importer 2020-01-02 00:28:16 PST
Comment 2 Keith Rollin 2020-01-02 00:30:02 PST
Created attachment 386598 [details]
Comment 3 WebKit Commit Bot 2020-01-02 13:43:36 PST
Comment on attachment 386598 [details]

Clearing flags on attachment: 386598

Committed r253981: <https://trac.webkit.org/changeset/253981>
Comment 4 WebKit Commit Bot 2020-01-02 13:43:38 PST
All reviewed patches have been landed.  Closing bug.