Bug 205705 - Reformat WebPage logging
Summary: Reformat WebPage logging
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Keywords: InRadar
Depends on:
Reported: 2020-01-02 18:12 PST by Keith Rollin
Modified: 2020-01-04 10:23 PST (History)
4 users (show)

See Also:

Patch (6.73 KB, patch)
2020-01-02 18:15 PST, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-01-02 18:12:22 PST
Update the format used by WebPage in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form:

    <object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>

So, for example:

    0x7f83ba009208 - WebPage (webPageID=15) - Adding a reason 1 to freeze layer tree (now 1); old reasons were 0


    0x7f83ba009208 - [webPageID=15] WebPage::freezeLayerTree: Adding a reason to freeze layer tree (reason=1, new=1, old=0)
Comment 1 Radar WebKit Bug Importer 2020-01-02 18:12:32 PST
Comment 2 Keith Rollin 2020-01-02 18:15:42 PST
Created attachment 386652 [details]
Comment 3 WebKit Commit Bot 2020-01-04 10:23:15 PST
Comment on attachment 386652 [details]

Clearing flags on attachment: 386652

Committed r254033: <https://trac.webkit.org/changeset/254033>
Comment 4 WebKit Commit Bot 2020-01-04 10:23:16 PST
All reviewed patches have been landed.  Closing bug.