WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
201546
[WKTR] Drop TestRunner.setPrivateBrowsingEnabled_DEPRECATED()
https://bugs.webkit.org/show_bug.cgi?id=201546
Summary
[WKTR] Drop TestRunner.setPrivateBrowsingEnabled_DEPRECATED()
Chris Dumez
Reported
2019-09-06 09:21:43 PDT
Drop TestRunner.setPrivateBrowsingEnabled_DEPRECATED() in WebKitTestRunner since it does not do the right thing for WK2 and we have a better alternative.
Attachments
WIP Patch
(2.19 KB, patch)
2019-09-06 09:22 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
WIP Patch
(2.22 KB, patch)
2019-09-06 18:55 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
WIP Patch
(2.35 KB, patch)
2019-09-09 20:30 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(17.80 KB, patch)
2019-09-11 15:52 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(18.82 KB, patch)
2019-09-11 15:52 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(22.17 KB, patch)
2019-09-12 09:30 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(5)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2019-09-06 09:22:12 PDT
Created
attachment 378198
[details]
WIP Patch
Chris Dumez
Comment 2
2019-09-06 18:55:05 PDT
Created
attachment 378263
[details]
WIP Patch
Chris Dumez
Comment 3
2019-09-06 20:54:46 PDT
Failures: http/tests/cache-storage/cache-persistency.https.html http/tests/cookies/private-cookie-storage.html http/tests/workers/service/serviceworker-private-browsing.https.html //
Bug 201574
. imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html http/tests/workers/service/basic-register.html storage/domstorage/localstorage/private-browsing-affects-storage.html //
Bug 201547
.
Chris Dumez
Comment 4
2019-09-09 20:30:50 PDT
Created
attachment 378440
[details]
WIP Patch
Chris Dumez
Comment 5
2019-09-10 08:32:56 PDT
Remaining failures: http/tests/cache-storage/cache-persistency.https.html http/tests/cookies/private-cookie-storage.html
Chris Dumez
Comment 6
2019-09-11 15:52:06 PDT
Created
attachment 378587
[details]
Patch
Chris Dumez
Comment 7
2019-09-11 15:52:53 PDT
Created
attachment 378588
[details]
Patch
Chris Dumez
Comment 8
2019-09-12 08:55:36 PDT
Comment on
attachment 378588
[details]
Patch Looks like I need to update a couple more tests to make iOS-wk2 happy.
Chris Dumez
Comment 9
2019-09-12 09:27:29 PDT
***
Bug 201722
has been marked as a duplicate of this bug. ***
Chris Dumez
Comment 10
2019-09-12 09:30:24 PDT
Created
attachment 378647
[details]
Patch
WebKit Commit Bot
Comment 11
2019-09-12 15:12:32 PDT
Comment on
attachment 378647
[details]
Patch Clearing flags on attachment: 378647 Committed
r249817
: <
https://trac.webkit.org/changeset/249817
>
WebKit Commit Bot
Comment 12
2019-09-12 15:12:34 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13
2019-09-12 15:13:22 PDT
<
rdar://problem/55319339
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug