Bug 201590 - Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/workers/service/basic-register.html
Summary: Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/wo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 201546
  Show dependency tree / graph
 
Reported: 2019-09-08 10:04 PDT by Chris Dumez
Modified: 2019-09-09 10:19 PDT (History)
6 users (show)

See Also:

Attachments
Patch (9.87 KB, patch)
2019-09-08 10:25 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (9.85 KB, patch)
2019-09-09 09:39 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-08 10:04:22 PDT 
Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/workers/service/basic-register.html.
Comment 1 Chris Dumez 2019-09-08 10:25:20 PDT 
Created attachment 378328 [details]
Patch
Comment 2 youenn fablet 2019-09-08 23:10:17 PDT 
Comment on attachment 378328 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378328&action=review

> Tools/ChangeLog:8
> +        Add a new API test to check that if the default session registers a service workers, the

s/workers/worker/

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1508
> +    configuration.get().websiteDataStore = [WKWebsiteDataStore nonPersistentDataStore];

We were using an ephemeral session in the layout test because that was all we had.
This test could be written with a non ephemeral session.
Comment 3 Chris Dumez 2019-09-09 09:39:51 PDT 
Created attachment 378375 [details]
Patch
Comment 4 WebKit Commit Bot 2019-09-09 10:18:31 PDT 
Comment on attachment 378375 [details]
Patch

Clearing flags on attachment: 378375

Committed r249648: <https://trac.webkit.org/changeset/249648>
Comment 5 WebKit Commit Bot 2019-09-09 10:18:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-09 10:19:20 PDT 
<rdar://problem/55186932>
Comment 7 Radar WebKit Bug Importer 2019-09-09 10:19:24 PDT 
<rdar://problem/55186936>