Bug 201648 - Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/cookies/private-cookie-storage.html
Summary: Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/co...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 201546
  Show dependency treegraph
 
Reported: 2019-09-10 10:23 PDT by Chris Dumez
Modified: 2019-09-10 17:36 PDT (History)
12 users (show)

See Also:


Attachments
Patch (6.78 KB, patch)
2019-09-10 10:27 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews213 for win-future (13.78 MB, application/zip)
2019-09-10 12:11 PDT, Build Bot
no flags Details
Patch (18.23 KB, patch)
2019-09-10 12:37 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (18.25 KB, patch)
2019-09-10 13:17 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (18.21 KB, patch)
2019-09-10 14:17 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (18.09 KB, patch)
2019-09-10 15:02 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-10 10:23:00 PDT
Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/cookies/private-cookie-storage.html.
Comment 1 Chris Dumez 2019-09-10 10:27:08 PDT
Created attachment 378468 [details]
Patch
Comment 2 Build Bot 2019-09-10 12:10:53 PDT
Comment on attachment 378468 [details]
Patch

Attachment 378468 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13020346

New failing tests:
http/tests/cookies/private-cookie-storage.html
Comment 3 Build Bot 2019-09-10 12:11:02 PDT
Created attachment 378473 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 4 Chris Dumez 2019-09-10 12:37:53 PDT
Created attachment 378474 [details]
Patch
Comment 5 Chris Dumez 2019-09-10 13:17:04 PDT
Created attachment 378478 [details]
Patch
Comment 6 Chris Dumez 2019-09-10 14:17:05 PDT
Created attachment 378491 [details]
Patch
Comment 7 Chris Dumez 2019-09-10 15:02:00 PDT
Created attachment 378497 [details]
Patch
Comment 8 Chris Dumez 2019-09-10 16:43:21 PDT
Alex, could you please take another look? I had to add test infrastructure for Windows to get the test working there.
Comment 9 Alex Christensen 2019-09-10 16:50:38 PDT
Comment on attachment 378497 [details]
Patch

Sure
Comment 10 WebKit Commit Bot 2019-09-10 17:35:25 PDT
Comment on attachment 378497 [details]
Patch

Clearing flags on attachment: 378497

Committed r249746: <https://trac.webkit.org/changeset/249746>
Comment 11 WebKit Commit Bot 2019-09-10 17:35:27 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2019-09-10 17:36:31 PDT
<rdar://problem/55244424>
Comment 13 Radar WebKit Bug Importer 2019-09-10 17:36:32 PDT
<rdar://problem/55244425>