RESOLVED FIXED 201475
[WK2] Add proper layout test support for ephemeral sessions 
https://bugs.webkit.org/show_bug.cgi?id=201475
Summary [WK2] Add proper layout test support for ephemeral sessions
Chris Dumez
Reported 2019-09-04 15:52:19 PDT
Add proper layout test support for ephemeral sessions. testRunner.setPrivateBrowsingEnabled() merely overrides the Page's sessionID in the WebContent process, which is a hack and does not truly enable private browsing.
Attachments
WIP Patch (17.17 KB, patch)
2019-09-04 16:01 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (62.34 KB, patch)
2019-09-05 09:15 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (62.45 KB, patch)
2019-09-05 10:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (64.03 KB, patch)
2019-09-05 10:56 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-09-04 16:01:53 PDT
Created attachment 378022 [details] WIP Patch
youenn fablet
Comment 2 2019-09-04 23:38:41 PDT
Comment on attachment 378022 [details] WIP Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378022&action=review > LayoutTests/crypto/subtle/rsa-indexeddb-private.html:2 > <!DOCTYPE html> A lot of tests are suffixed with -private.html and are then expected to run in private browsing mode (see js-test-pre.js). I slightly tend to prefer webkit-test-runner approach but we could also consistently use the name suffix approach. It seems that only a few files would need to be renamed.
Chris Dumez
Comment 3 2019-09-05 09:15:33 PDT
Created attachment 378088 [details] Patch
Chris Dumez
Comment 4 2019-09-05 10:10:05 PDT
Created attachment 378092 [details] Patch
Chris Dumez
Comment 5 2019-09-05 10:56:37 PDT
Created attachment 378097 [details] Patch
WebKit Commit Bot
Comment 6 2019-09-05 14:12:12 PDT
Comment on attachment 378097 [details] Patch Clearing flags on attachment: 378097 Committed r249542: <https://trac.webkit.org/changeset/249542>
WebKit Commit Bot
Comment 7 2019-09-05 14:12:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-09-05 14:13:20 PDT
<rdar://problem/55083700>
Note You need to log in before you can comment on or make changes to this bug.