Bug 201475 - [WK2] Add proper layout test support for ephemeral sessions
Summary: [WK2] Add proper layout test support for ephemeral sessions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 201519 201522 201523 201524 201546
  Show dependency tree / graph
 
Reported: 2019-09-04 15:52 PDT by Chris Dumez
Modified: 2019-09-06 10:24 PDT (History)
7 users (show)

See Also:

Attachments
WIP Patch (17.17 KB, patch)
2019-09-04 16:01 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (62.34 KB, patch)
2019-09-05 09:15 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (62.45 KB, patch)
2019-09-05 10:10 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (64.03 KB, patch)
2019-09-05 10:56 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-04 15:52:19 PDT 
Add proper layout test support for ephemeral sessions. testRunner.setPrivateBrowsingEnabled() merely overrides the Page's sessionID in the WebContent process, which is a hack and does not truly enable private browsing.
Comment 1 Chris Dumez 2019-09-04 16:01:53 PDT 
Created attachment 378022 [details]
WIP Patch
Comment 2 youenn fablet 2019-09-04 23:38:41 PDT 
Comment on attachment 378022 [details]
WIP Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378022&action=review

> LayoutTests/crypto/subtle/rsa-indexeddb-private.html:2
>  <!DOCTYPE html>

A lot of tests are suffixed with -private.html and are then expected to run in private browsing mode (see js-test-pre.js).
I slightly tend to prefer webkit-test-runner approach but we could also consistently use the name suffix approach.
It seems that only a few files would need to be renamed.
Comment 3 Chris Dumez 2019-09-05 09:15:33 PDT 
Created attachment 378088 [details]
Patch
Comment 4 Chris Dumez 2019-09-05 10:10:05 PDT 
Created attachment 378092 [details]
Patch
Comment 5 Chris Dumez 2019-09-05 10:56:37 PDT 
Created attachment 378097 [details]
Patch
Comment 6 WebKit Commit Bot 2019-09-05 14:12:12 PDT 
Comment on attachment 378097 [details]
Patch

Clearing flags on attachment: 378097

Committed r249542: <https://trac.webkit.org/changeset/249542>
Comment 7 WebKit Commit Bot 2019-09-05 14:12:13 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-09-05 14:13:20 PDT 
<rdar://problem/55083700>