Bug 201519 - Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
Summary: Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 201475
Blocks:
  Show dependency tree / graph
 
Reported: 2019-09-05 15:07 PDT by Chris Dumez
Modified: 2019-09-05 22:58 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.77 KB, patch)
2019-09-05 15:09 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-05 15:07:22 PDT 
Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing.
Comment 1 Chris Dumez 2019-09-05 15:09:36 PDT 
Created attachment 378127 [details]
Patch
Comment 2 Alex Christensen 2019-09-05 20:15:46 PDT 
Comment on attachment 378127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378127&action=review

> Tools/WebKitTestRunner/TestOptions.cpp:61
> +    return pathContains(pathOrURL, "w3c/IndexedDB-private-browsing") || pathContains(pathOrURL, "w3c\\IndexedDB-private-browsing");

Maybe pathContains should be made to replace '\\' with '/' before doing the comparison so we don't need both of these for all call sites.
Comment 3 WebKit Commit Bot 2019-09-05 22:57:29 PDT 
Comment on attachment 378127 [details]
Patch

Clearing flags on attachment: 378127

Committed r249564: <https://trac.webkit.org/changeset/249564>
Comment 4 WebKit Commit Bot 2019-09-05 22:57:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-09-05 22:58:18 PDT 
<rdar://problem/55101171>