RESOLVED FIXED 201522
Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in js-test.js 
https://bugs.webkit.org/show_bug.cgi?id=201522
Summary Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in js-test.js
Chris Dumez
Reported 2019-09-05 15:25:58 PDT
Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in js-test.js since it does not do the right thing for WebKit2.
Attachments
Patch (181.48 KB, patch)
2019-09-05 15:30 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews215 for win-future (13.66 MB, application/zip)
2019-09-05 17:48 PDT, EWS Watchlist 		no flags
Details
Patch (182.24 KB, patch)
2019-09-05 18:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (182.24 KB, patch)
2019-09-05 19:35 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-09-05 15:30:26 PDT
Created attachment 378130 [details] Patch
EWS Watchlist
Comment 2 2019-09-05 17:48:45 PDT
Comment on attachment 378130 [details] Patch Attachment 378130 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13002481 New failing tests: storage/indexeddb/transaction-error-private.html storage/indexeddb/odd-strings-private.html storage/indexeddb/version-change-abort-private.html storage/indexeddb/modern/transaction-scheduler-6-private.html storage/indexeddb/modern/transaction-scheduler-2-private.html storage/indexeddb/modern/transaction-scheduler-5-private.html storage/indexeddb/modern/transaction-scheduler-1-private.html storage/indexeddb/exception-in-event-aborts-private.html storage/indexeddb/transaction-coordination-within-database-private.html
EWS Watchlist
Comment 3 2019-09-05 17:48:48 PDT
Created attachment 378141 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Chris Dumez
Comment 4 2019-09-05 18:28:32 PDT
Comment on attachment 378130 [details] Patch Well, that is interesting, I will investigate the failures.
Chris Dumez
Comment 5 2019-09-05 18:44:26 PDT
Created attachment 378147 [details] Patch
Chris Dumez
Comment 6 2019-09-05 19:35:38 PDT
Created attachment 378152 [details] Patch
WebKit Commit Bot
Comment 7 2019-09-05 22:06:44 PDT
Comment on attachment 378152 [details] Patch Clearing flags on attachment: 378152 Committed r249563: <https://trac.webkit.org/changeset/249563>
WebKit Commit Bot
Comment 8 2019-09-05 22:06:46 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-09-05 22:07:21 PDT
<rdar://problem/55099923>
Radar WebKit Bug Importer
Comment 10 2019-09-05 22:07:22 PDT
<rdar://problem/55099925>
Note You need to log in before you can comment on or make changes to this bug.