Bug 201547 - Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test
Summary: Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 201546
  Show dependency treegraph
 
Reported: 2019-09-06 10:24 PDT by Chris Dumez
Modified: 2019-09-07 22:12 PDT (History)
7 users (show)

See Also:


Attachments
Patch (15.65 KB, patch)
2019-09-06 14:50 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (19.04 KB, patch)
2019-09-07 12:05 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-06 10:24:19 PDT
Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test so it can use a true ephemeral session instead of the testRunner.setPrivateBrowsingEnabled_DEPRECATED() hack.
Comment 1 Chris Dumez 2019-09-06 14:50:13 PDT
Created attachment 378237 [details]
Patch
Comment 2 Alex Christensen 2019-09-07 09:16:03 PDT
Comment on attachment 378237 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378237&action=review

> LayoutTests/storage/domstorage/localstorage/resources/private-browsing-1.html:-47
> -    window.open("private-browsing-2.html", "_blank");

window.open isn't in your new test.  This is what you were talking to us today about, right?
Comment 3 Chris Dumez 2019-09-07 10:55:32 PDT
(In reply to Alex Christensen from comment #2)
> Comment on attachment 378237 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=378237&action=review
> 
> > LayoutTests/storage/domstorage/localstorage/resources/private-browsing-1.html:-47
> > -    window.open("private-browsing-2.html", "_blank");
> 
> window.open isn't in your new test.  This is what you were talking to us
> today about, right?

Yes, it is bigger due to the bug I mentioned so I wanted to split the window open case out.
Comment 4 Chris Dumez 2019-09-07 12:01:06 PDT
Comment on attachment 378237 [details]
Patch

Will beef up the API test a bit.
Comment 5 Chris Dumez 2019-09-07 12:05:02 PDT
Created attachment 378298 [details]
Patch
Comment 6 WebKit Commit Bot 2019-09-07 22:11:54 PDT
Comment on attachment 378298 [details]
Patch

Clearing flags on attachment: 378298

Committed r249625: <https://trac.webkit.org/changeset/249625>
Comment 7 WebKit Commit Bot 2019-09-07 22:11:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-09-07 22:12:15 PDT
<rdar://problem/55155427>
Comment 9 Radar WebKit Bug Importer 2019-09-07 22:12:16 PDT
<rdar://problem/55155428>