Bug 201547 – Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Chris Dumez]

Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test so it can use a true ephemeral session instead of the testRunner.setPrivateBrowsingEnabled_DEPRECATED() hack.

[Chris Dumez]

Created attachment 378237 [details]
Patch

[Alex Christensen]

Comment on attachment 378237 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378237&action=review

> LayoutTests/storage/domstorage/localstorage/resources/private-browsing-1.html:-47
> -    window.open("private-browsing-2.html", "_blank");

window.open isn't in your new test.  This is what you were talking to us today about, right?

[Chris Dumez]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 378237 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=378237&action=review
> 
> > LayoutTests/storage/domstorage/localstorage/resources/private-browsing-1.html:-47
> > -    window.open("private-browsing-2.html", "_blank");
> 
> window.open isn't in your new test.  This is what you were talking to us
> today about, right?

Yes, it is bigger due to the bug I mentioned so I wanted to split the window open case out.

[Chris Dumez]

Comment on attachment 378237 [details]
Patch

Will beef up the API test a bit.

[Chris Dumez]

Created attachment 378298 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 378298 [details]
Patch

Clearing flags on attachment: 378298

Committed r249625: <https://trac.webkit.org/changeset/249625>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55155427>

[Radar WebKit Bug Importer]

<rdar://problem/55155428>