WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
201574
Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test
https://bugs.webkit.org/show_bug.cgi?id=201574
Summary
Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html ...
Chris Dumez
Reported
2019-09-06 20:46:34 PDT
Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test so that we truly test private browsing. testRunner.setPrivateBrowsingEnabled_DEPRECATED() is a hack which does not work well for WK2.
Attachments
Patch
(13.66 KB, patch)
2019-09-06 20:51 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(13.23 KB, patch)
2019-09-07 11:26 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2019-09-06 20:51:17 PDT
Created
attachment 378271
[details]
Patch
Alex Christensen
Comment 2
2019-09-07 09:22:31 PDT
Comment on
attachment 378271
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=378271&action=review
> Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1419 > + auto ephemeralConfiguration = adoptNS([[WKWebViewConfiguration alloc] init]);
In order for this to be an equivalent test, don't you need to set the processPool to be the same as the defaultWebView?
Chris Dumez
Comment 3
2019-09-07 10:58:12 PDT
(In reply to Alex Christensen from
comment #2
)
> Comment on
attachment 378271
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=378271&action=review
> > > Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1419 > > + auto ephemeralConfiguration = adoptNS([[WKWebViewConfiguration alloc] init]); > > In order for this to be an equivalent test, don't you need to set the > processPool to be the same as the defaultWebView?
Well, that is a good point. For some reason, I assumed this was the default behavior :/ will fix.
Chris Dumez
Comment 4
2019-09-07 11:26:42 PDT
Created
attachment 378297
[details]
Patch
Chris Dumez
Comment 5
2019-09-07 11:26:57 PDT
(In reply to Chris Dumez from
comment #3
)
> (In reply to Alex Christensen from
comment #2
) > > Comment on
attachment 378271
[details]
> > Patch > > > > View in context: > >
https://bugs.webkit.org/attachment.cgi?id=378271&action=review
> > > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1419 > > > + auto ephemeralConfiguration = adoptNS([[WKWebViewConfiguration alloc] init]); > > > > In order for this to be an equivalent test, don't you need to set the > > processPool to be the same as the defaultWebView? > > Well, that is a good point. For some reason, I assumed this was the default > behavior :/ will fix.
Done.
WebKit Commit Bot
Comment 6
2019-09-07 22:26:57 PDT
Comment on
attachment 378297
[details]
Patch Clearing flags on attachment: 378297 Committed
r249626
: <
https://trac.webkit.org/changeset/249626
>
WebKit Commit Bot
Comment 7
2019-09-07 22:26:59 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8
2019-09-07 22:27:16 PDT
<
rdar://problem/55155561
>
Radar WebKit Bug Importer
Comment 9
2019-09-07 22:27:17 PDT
<
rdar://problem/55155563
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug