Bug 121859 – [mac] Stop using DrawingAreaImpl on PLATFORM(MAC)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

We should be using TiledCoreAnimationDrawingArea everywhere, including for tests. It should be the only drawing area you can acquire when making a WKView, and should happen automatically.

This would be relatively straightforward, except for two things:

* TCADA currently explicitly forces use of threaded scrolling, which breaks a number of tests. These two things aren't necessarily related and should be decoupled.

* Using tiled drawing means the layer tree dumps will be slightly different for some tests, so we need to adjust layer tree output to be consistent (otherwise Mac-WK2 will be different from Mac-WK1 and all the other ports).

[Radar WebKit Bug Importer]

<rdar://problem/15069359>

[Tim Horton]

Created attachment 213141 [details]
preliminary

[Tim Horton]

*** Bug 122006 has been marked as a duplicate of this bug. ***

[Tim Horton]

*** Bug 122007 has been marked as a duplicate of this bug. ***

[EFL EWS Bot]

Comment on attachment 213141 [details]
preliminary

Attachment 213141 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/2905264

[Tim Horton]

(In reply to comment #5)
> (From update of attachment 213141 [details])
> Attachment 213141 [details] did not pass efl-wk2-ews (efl-wk2):
> Output: http://webkit-queues.appspot.com/results/2905264

>c++: internal compiler error: Killed (program cc1plus)
>Please submit a full bug report, with preprocessed source if appropriate.
> See <file:///usr/share/doc/gcc-4.7/README.Bugs> for instructions.
> make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/html/canvas/WebGLRenderingContext.cpp.o] Error 4

Sounds like something that I didn't cause.

[Tim Horton]

Created attachment 213195 [details]
patch

[Tim Horton]

I filed a bunch of bugs about test regressions:

https://bugs.webkit.org/show_bug.cgi?id=122233 - A variety of regions tests have overflow which is not accounted for, and fail
https://bugs.webkit.org/show_bug.cgi?id=122234 - A bunch of tests fail with minor color mismatches (I'm going to look at this one next, along with some other things)
https://bugs.webkit.org/show_bug.cgi?id=122235 - Some css3/ tests fail with fringing around tiled background-images that intersect tile boundaries
https://bugs.webkit.org/show_bug.cgi?id=122237 - fast/table/crash-section-logical-height-changed-needsCellRecalc.html asserts
https://bugs.webkit.org/show_bug.cgi?id=122238 - fast/layers/no-clipping-overflow-hidden-added-after-transform.html fails with tiled drawing

[Tim Horton]

http://trac.webkit.org/changeset/156793