Bug 121856 – Make explicit our use of sRGB as the 'untagged' color space

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: Layout and Rendering

[Tim Horton]

On Mountain Lion, CG's default interpretation of DeviceRGB is 'sRGB', whereas CG with 'drawsAsynchronously' on interprets DeviceRGB to be "untagged", flowing unmatched into the context it's painted into. To make everything match up and to make our behavior consistent on all platforms, we should just use sRGB instead of device everywhere, explicitly, matching the CSS and SVG specs.

We need to do some performance testing, and investigate the situation with plugins.

[Radar WebKit Bug Importer]

<rdar://problem/15069231>

[Tim Horton]

On Mavericks, both interpret DeviceRGB as sRGB.

[Tim Horton]

Created attachment 237996 [details]
preliminary patch

[WebKit Commit Bot]

Attachment 237996 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:505:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:565:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 2 in 113 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 237996 [details]
preliminary patch

Attachment 237996 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6711950989852672

New failing tests:
svg/css/getComputedStyle-basic.xhtml
accessibility/content-editable-as-textarea.html
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html

[Build Bot]

Created attachment 238003 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 237996 [details]
preliminary patch

Attachment 237996 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5878020812308480

New failing tests:
svg/css/getComputedStyle-basic.xhtml
accessibility/content-editable-as-textarea.html
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html

[Build Bot]

Created attachment 238005 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 237996 [details]
preliminary patch

Attachment 237996 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4542362218921984

New failing tests:
svg/css/getComputedStyle-basic.xhtml
accessibility/content-editable-as-textarea.html
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html

[Build Bot]

Created attachment 238009 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 237996 [details]
preliminary patch

Attachment 237996 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5785467488305152

New failing tests:
svg/css/getComputedStyle-basic.xhtml
accessibility/content-editable-as-textarea.html
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html

[Build Bot]

Created attachment 238011 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 237996 [details]
preliminary patch

Attachment 237996 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6359109762809856

New failing tests:
svg/css/getComputedStyle-basic.xhtml
accessibility/content-editable-as-textarea.html
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html

[Build Bot]

Created attachment 238014 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5