RESOLVED FIXED 121874
Tiled drawing should not imply threaded scrolling 
https://bugs.webkit.org/show_bug.cgi?id=121874
Summary Tiled drawing should not imply threaded scrolling
Tim Horton
Reported 2013-09-24 15:48:26 PDT
They should be separate settings (though threaded scrolling will required tiled drawing, I think). Needed to separate/reduce the layout test churn for 121859 and for general sanity. We can make layout tests use threaded scrolling as well at a future date.
Attachments
patch (30.30 KB, patch)
2013-09-25 18:07 PDT, Tim Horton 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-09-24 15:49:11 PDT
<rdar://problem/15071494>
Tim Horton
Comment 2 2013-09-25 11:27:29 PDT
This is kind of messy, because lots of things in WebCore depend on the existence of a scrolling coordinator to mean “do what I should do if we’re using tiled drawing” (use a tiled backing for the root, use the shadow and ‘linen’ background view, etc.). I can either a) plumb some new thing down to WebCore that means ‘we’re using tiled drawing’; whether that be a setting or whatever (?) b) do this at the same time as ‘remove-DrawingAreaImpl and always use tiled drawing’, which would mean that we could just (for Mac) always do these things
Tim Horton
Comment 3 2013-09-25 18:07:54 PDT
Created attachment 212646 [details] patch
Anders Carlsson
Comment 4 2013-09-25 19:04:25 PDT
Comment on attachment 212646 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=212646&action=review > Source/WebKit2/WebProcess/WebPage/DrawingArea.h:92 > + virtual bool shouldUseTiledBackingForFrame(const WebCore::Frame&) { return false; } Maybe this should take a frame view?
Tim Horton
Comment 5 2013-09-26 10:33:35 PDT
http://trac.webkit.org/changeset/156472
Note You need to log in before you can comment on or make changes to this bug.