Bug 122172 - Tiled drawing GraphicsLayer tree dumps should match non-tiled more closely
Summary: Tiled drawing GraphicsLayer tree dumps should match non-tiled more closely
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Depends on:
Blocks: 121859
  Show dependency treegraph
Reported: 2013-10-01 12:54 PDT by Tim Horton
Modified: 2013-10-01 16:41 PDT (History)
6 users (show)

See Also:

preliminary patch (30.40 KB, patch)
2013-10-01 13:11 PDT, Tim Horton
buildbot: commit-queue-
Details | Formatted Diff | Diff
fix windows (30.58 KB, patch)
2013-10-01 14:07 PDT, Tim Horton
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-10-01 12:54:46 PDT
So that when we turn on tiled drawing for mac-wk2 on all tests, we don't need separate results for every test that deals with GraphicsLayer tree dumps. This *will* require rebaselining the current tiled-drawing tests, though.
Comment 1 Tim Horton 2013-10-01 13:11:36 PDT
Created attachment 213115 [details]
preliminary patch
Comment 2 Build Bot 2013-10-01 13:50:21 PDT
Comment on attachment 213115 [details]
preliminary patch

Attachment 213115 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/2908159
Comment 3 Tim Horton 2013-10-01 14:07:43 PDT
Created attachment 213118 [details]
fix windows
Comment 4 Anders Carlsson 2013-10-01 16:30:48 PDT
Comment on attachment 213118 [details]
fix windows

View in context: https://bugs.webkit.org/attachment.cgi?id=213118&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:2095
> +    return (m_isMainFrameRenderViewLayer && layer && layer == m_childContainmentLayer.get());

No need for the parentheses here.
Comment 5 Tim Horton 2013-10-01 16:41:43 PDT