Bug 118353 – Get rid of multiple inheritance support from the bindings generators

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Remove multiple inheritance support from the bindings generator as this is no longer supported in Web IDL and it makes the generator more complex than it needs to be.

Multiple inheritance support should no longer be needed once our SVG interfaces have all been updated to use Web IDL 'implements' statements instead (as per the latest SVG2 specification).

[Chris Dumez]

Created attachment 206448 [details]
Patch

[Kentaro Hara]

Comment on attachment 206448 [details]
Patch

This looks great. Thanks for doing this.

[Build Bot]

Comment on attachment 206448 [details]
Patch

Attachment 206448 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1051216

[Build Bot]

Comment on attachment 206448 [details]
Patch

Attachment 206448 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/936603

[Chris Dumez]

Hmm, mac port uses multiple inheritance at least in one place:
] interface Node
#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
    : Object, EventTarget
#endif /* defined(LANGUAGE_OBJECTIVE_C) */
 {

I need to investigate how to solve this.

[Chris Dumez]

Created attachment 206461 [details]
Test for mac ews

[Build Bot]

Comment on attachment 206461 [details]
Test for mac ews

Attachment 206461 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1059085

[Build Bot]

Comment on attachment 206461 [details]
Test for mac ews

Attachment 206461 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/954899

[Chris Dumez]

Created attachment 206510 [details]
Another test for mac-ews

[Build Bot]

Comment on attachment 206510 [details]
Another test for mac-ews

Attachment 206510 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/973967

[Build Bot]

Comment on attachment 206510 [details]
Another test for mac-ews

Attachment 206510 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/973968

[Chris Dumez]

Created attachment 206531 [details]
Another test for mac-ews

[Build Bot]

Comment on attachment 206531 [details]
Another test for mac-ews

Attachment 206531 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1045283

[Build Bot]

Comment on attachment 206531 [details]
Another test for mac-ews

Attachment 206531 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1063104

[Chris Dumez]

Created attachment 206540 [details]
Another test for mac-ews

[Build Bot]

Comment on attachment 206540 [details]
Another test for mac-ews

Attachment 206540 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1064101

[Build Bot]

Comment on attachment 206540 [details]
Another test for mac-ews

Attachment 206540 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1054317

[Chris Dumez]

Created attachment 206730 [details]
Another test for mac-ews

[Build Bot]

Comment on attachment 206730 [details]
Another test for mac-ews

Attachment 206730 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1084114

[Build Bot]

Comment on attachment 206730 [details]
Another test for mac-ews

Attachment 206730 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1086088

[Chris Dumez]

Created attachment 206754 [details]
Another test for mac-ews

[Build Bot]

Comment on attachment 206754 [details]
Another test for mac-ews

Attachment 206754 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1089169

[Build Bot]

Comment on attachment 206754 [details]
Another test for mac-ews

Attachment 206754 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1085179

[Chris Dumez]

Created attachment 206766 [details]
Another test for mac-ews

[Chris Dumez]

Created attachment 206769 [details]
Patch

[Chris Dumez]

@haraken: Could you please take another look? I had to take a more conservative approach and keep supporting multiple inheritance in the IDL parser. Unfortunately, the ObjC bindings generator still relies on multiple inheritance for the Node interface and I don't understand those bindings enough to fix the issue :/

[Kentaro Hara]

Comment on attachment 206769 [details]
Patch

OK, lgtm. Landing easy parts first makes sense.

[Chris Dumez]

Created attachment 206777 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 206777 [details]
Patch for landing

Rejecting attachment 206777 [details] from commit-queue.

New failing tests:
compositing/reflections/load-video-in-reflection.html
Full output: http://webkit-queues.appspot.com/results/1086187

[WebKit Commit Bot]

Created attachment 206780 [details]
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Chris Dumez]

Comment on attachment 206777 [details]
Patch for landing

Failure is unrelated, cq+ again.

[WebKit Commit Bot]

Comment on attachment 206777 [details]
Patch for landing

Clearing flags on attachment: 206777

Committed r152725: <http://trac.webkit.org/changeset/152725>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.