Bug 118029 - Stop inheriting SVGExternalResourcesRequired, SVGFitToViewBox and SVGZoomAndPan
Summary: Stop inheriting SVGExternalResourcesRequired, SVGFitToViewBox and SVGZoomAndPan
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: BlinkMergeCandidate
Depends on: 118014
Blocks: 118353
  Show dependency treegraph
 
Reported: 2013-06-25 22:57 PDT by Ryosuke Niwa
Modified: 2013-07-03 04:35 PDT (History)
12 users (show)

See Also:


Attachments
Patch (25.50 KB, patch)
2013-06-26 04:53 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-06-25 22:57:50 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/bd7550a95b92f2efd782f8e141eb2636025c5bb9

Stop inheriting SVGExternalResourcesRequired, SVGFitToViewBox and SVGZoomAndPan
in the IDL and use implements statements instead.

This is one step towards getting rid of multiple inheritance in the SVG code
and matching the latest specification:
http://www.w3.org/TR/SVG2/types.html#BasicDOMInterfaces

There is no webexposed behavior change.
Comment 1 Chris Dumez 2013-06-26 04:53:18 PDT
Created attachment 205471 [details]
Patch
Comment 2 Kentaro Hara 2013-06-26 05:00:59 PDT
Comment on attachment 205471 [details]
Patch

ok
Comment 3 WebKit Commit Bot 2013-06-26 07:28:30 PDT
Comment on attachment 205471 [details]
Patch

Clearing flags on attachment: 205471

Committed r151988: <http://trac.webkit.org/changeset/151988>
Comment 4 WebKit Commit Bot 2013-06-26 07:28:33 PDT
All reviewed patches have been landed.  Closing bug.