Bug 118014 - Get rid of multiple inheritence for SVGViewElement interface
Summary: Get rid of multiple inheritence for SVGViewElement interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks: 118029 118353
  Show dependency tree / graph
 
Reported: 2013-06-25 19:44 PDT by Ryosuke Niwa
Modified: 2013-07-03 04:35 PDT (History)
17 users (show)

See Also:

Attachments
Patch (25.92 KB, patch)
2013-06-25 23:47 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-06-25 19:44:13 PDT 
Consider merging https://chromium.googlesource.com/chromium/blink/+/b6db991c6871d8ed29f3ec23028d38100be7e556

Get rid of multiple inheritence for SVGViewElement interface

Web IDL no longer supports multiple inheritence. As per the latest
specification SVGViewElement should only inherit from SVGElement.
'implements' statements are used for the rest. This patch refactors
the IDL files to match the latest specification:
http://www.w3.org/TR/SVG2/linking.html#InterfaceSVGViewElement

Note that there is a WebExposed change as SVGZoomAndPan used to be
exposed on the Window and it is not anymore. SVGZoomAndPan merely
supplements SVGViewElement and should not be exposed to JavaScript
according to the latest specification.
Comment 1 Chris Dumez 2013-06-25 23:47:41 PDT 
Created attachment 205456 [details]
Patch
Comment 2 Kentaro Hara 2013-06-25 23:51:23 PDT 
Comment on attachment 205456 [details]
Patch

LGTM
Comment 3 WebKit Commit Bot 2013-06-26 03:40:24 PDT 
Comment on attachment 205456 [details]
Patch

Clearing flags on attachment: 205456

Committed r151985: <http://trac.webkit.org/changeset/151985>
Comment 4 WebKit Commit Bot 2013-06-26 03:40:27 PDT 
All reviewed patches have been landed.  Closing bug.