Bug 118351 - Have SVGTextContentElement inherit SVGGraphicsElement
Summary: Have SVGTextContentElement inherit SVGGraphicsElement
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://svgwg.org/svg2-draft/text.htm...
Keywords: BlinkMergeCandidate
Depends on:
Blocks: 118353
  Show dependency treegraph
Reported: 2013-07-03 03:54 PDT by Chris Dumez
Modified: 2013-07-04 11:49 PDT (History)
12 users (show)

See Also:

Patch (30.48 KB, patch)
2013-07-03 04:21 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-07-03 03:54:07 PDT
Have SVGTextContentElement inherit SVGGraphicsElement instead of
SVGStyledElement in order to match the latest SVG2 specification:

This patch also removes the SVGTransformable and SVGLocatable IDL
interfaces as they are no longer needed (were merged into
SVGGraphicsElement in the latest specification).

Conversion to absolute (user agent) coordinates in the svg/text
tests is fixed to use SVGGraphicsElement::getScreenCTM() instead
of SVGGraphicsElement::getTransformToElement(). The previous code
was working until now due to a bug in getTransformToElement(),
which was not taking into consideration the CTM of the
SVGTextElement (as it was not recognized as a "locatable" element).
Now that SVGTextElement inherits from SVGGraphicsElement, it is
properly recognized as a "locatable" element by

This is one step towards getting rid of multiple inheritance in
SVG and matching the latest SVG2 specification.

Corresponding Blink revision:
Comment 1 Chris Dumez 2013-07-03 04:21:53 PDT
Created attachment 205991 [details]
Comment 2 Dirk Schulze 2013-07-04 11:26:17 PDT
Comment on attachment 205991 [details]

Comment 3 WebKit Commit Bot 2013-07-04 11:49:35 PDT
Comment on attachment 205991 [details]

Clearing flags on attachment: 205991

Committed r152404: <http://trac.webkit.org/changeset/152404>
Comment 4 WebKit Commit Bot 2013-07-04 11:49:37 PDT
All reviewed patches have been landed.  Closing bug.