WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
118142
Update SVG interfaces to stop inheriting from SVGURIReference and SVGTests
https://bugs.webkit.org/show_bug.cgi?id=118142
Summary
Update SVG interfaces to stop inheriting from SVGURIReference and SVGTests
Chris Dumez
Reported
2013-06-27 10:39:45 PDT
We should Update SVG IDL interfaces to stop inheriting from SVGURIReference and SVGTests and use IDL implements statements instead. This is one step towards getting rid of multiple inheritance in SVG, which is no longer supported by Web IDL and to match the latest specification:
https://svgwg.org/svg2-draft/types.html#BasicDOMInterfaces
Corresponding Blink patches:
https://src.chromium.org/viewvc/blink?view=rev&revision=152806
https://src.chromium.org/viewvc/blink?view=rev&revision=152883
Attachments
Patch
(29.02 KB, patch)
2013-06-27 11:09 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2013-06-27 11:09:31 PDT
Created
attachment 205620
[details]
Patch
Ryosuke Niwa
Comment 2
2013-06-27 11:36:54 PDT
Comment on
attachment 205620
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=205620&action=review
> Source/WebCore/ChangeLog:13 > + No new tests, no behavior change.
Really? Shouldn't there be some Web-visible behavioral change?
Chris Dumez
Comment 3
2013-06-27 11:51:48 PDT
Comment on
attachment 205620
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=205620&action=review
>> Source/WebCore/ChangeLog:13 >> + No new tests, no behavior change. > > Really? Shouldn't there be some Web-visible behavioral change?
Yes, there is no web-visible behavior change. We are merely replacing inheritance by implements statements.
WebKit Commit Bot
Comment 4
2013-06-27 12:37:00 PDT
Comment on
attachment 205620
[details]
Patch Clearing flags on attachment: 205620 Committed
r152120
: <
http://trac.webkit.org/changeset/152120
>
WebKit Commit Bot
Comment 5
2013-06-27 12:37:04 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug