Bug 118142 - Update SVG interfaces to stop inheriting from SVGURIReference and SVGTests
Summary: Update SVG interfaces to stop inheriting from SVGURIReference and SVGTests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://svgwg.org/svg2-draft/types.ht...
Keywords: BlinkMergeCandidate
Depends on:
Blocks: 118353
  Show dependency tree / graph
 
Reported: 2013-06-27 10:39 PDT by Chris Dumez
Modified: 2013-07-03 04:35 PDT (History)
13 users (show)

See Also:

Attachments
Patch (29.02 KB, patch)
2013-06-27 11:09 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-06-27 10:39:45 PDT 
We should Update SVG IDL interfaces to stop inheriting from SVGURIReference and SVGTests and use IDL implements statements instead. This is one step towards getting rid of multiple inheritance in SVG, which is no longer supported by Web IDL and to match the latest specification:
https://svgwg.org/svg2-draft/types.html#BasicDOMInterfaces

Corresponding Blink patches:
https://src.chromium.org/viewvc/blink?view=rev&revision=152806
https://src.chromium.org/viewvc/blink?view=rev&revision=152883
Comment 1 Chris Dumez 2013-06-27 11:09:31 PDT 
Created attachment 205620 [details]
Patch
Comment 2 Ryosuke Niwa 2013-06-27 11:36:54 PDT 
Comment on attachment 205620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205620&action=review

> Source/WebCore/ChangeLog:13
> +        No new tests, no behavior change.

Really? Shouldn't there be some Web-visible behavioral change?
Comment 3 Chris Dumez 2013-06-27 11:51:48 PDT 
Comment on attachment 205620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205620&action=review

>> Source/WebCore/ChangeLog:13
>> +        No new tests, no behavior change.
> 
> Really? Shouldn't there be some Web-visible behavioral change?

Yes, there is no web-visible behavior change. We are merely replacing inheritance by implements statements.
Comment 4 WebKit Commit Bot 2013-06-27 12:37:00 PDT 
Comment on attachment 205620 [details]
Patch

Clearing flags on attachment: 205620

Committed r152120: <http://trac.webkit.org/changeset/152120>
Comment 5 WebKit Commit Bot 2013-06-27 12:37:04 PDT 
All reviewed patches have been landed.  Closing bug.