Bug 118349 – Remove ElementTimeControl and expose SVGAnimationElement

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Chris Dumez]

Remove ElementTimeControl IDL interface and move its attributes
to the SVGAnimationElement IDL interface as per the latest SVG2
specification:
https://svgwg.org/svg2-draft/animate.html#InterfaceSVGAnimationElement

Also remove [NoInterfaceObject] IDL extended attribute from
SVGAnimationElement as it is not present in the specification.

This is one step towards removing IDL multiple inheritance in SVG.

Corresponding Blink revision:
https://src.chromium.org/viewvc/blink?revision=153458&view=revision

[Chris Dumez]

Created attachment 205990 [details]
Patch

[Kentaro Hara]

Comment on attachment 205990 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205990&action=review

> Source/WebCore/svg/ElementTimeControl.idl:-30
> -    ObjCProtocol,

Looks like you removed [ObjCProtocol]. Is it OK?

[Chris Dumez]

Comment on attachment 205990 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205990&action=review

>> Source/WebCore/svg/ElementTimeControl.idl:-30
>> -    ObjCProtocol,
> 
> Looks like you removed [ObjCProtocol]. Is it OK?

Well, this extended attribute only applies to this interface (not the children). Since this interface is removed, I think it is OK. However, someone from the mac port should probably confirm as I am not familiar with the ObjC bindings. The mac ews are green so at least
there is that.

[Chris Dumez]

(In reply to comment #3)
> (From update of attachment 205990 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205990&action=review
> 
> >> Source/WebCore/svg/ElementTimeControl.idl:-30
> >> -    ObjCProtocol,
> > 
> > Looks like you removed [ObjCProtocol]. Is it OK?
> 
> Well, this extended attribute only applies to this interface (not the children). Since this interface is removed, I think it is OK. However, someone from the mac port should probably confirm as I am not familiar with the ObjC bindings. The mac ews are green so at least
> there is that.

Could someone who understand Objective C bindings confirm that this change is OK please?

[Timothy Hatcher]

Comment on attachment 205990 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205990&action=review

>>>> Source/WebCore/svg/ElementTimeControl.idl:-30
>>>> -    ObjCProtocol,
>>> 
>>> Looks like you removed [ObjCProtocol]. Is it OK?
>> 
>> Well, this extended attribute only applies to this interface (not the children). Since this interface is removed, I think it is OK. However, someone from the mac port should probably confirm as I am not familiar with the ObjC bindings. The mac ews are green so at least
>> there is that.
> 
> Could someone who understand Objective C bindings confirm that this change is OK please?

It is fine. We don't generate the ObjC DOM for SVG anymore.

[Chris Dumez]

(In reply to comment #5)
> (From update of attachment 205990 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205990&action=review
> 
> >>>> Source/WebCore/svg/ElementTimeControl.idl:-30
> >>>> -    ObjCProtocol,
> >>> 
> >>> Looks like you removed [ObjCProtocol]. Is it OK?
> >> 
> >> Well, this extended attribute only applies to this interface (not the children). Since this interface is removed, I think it is OK. However, someone from the mac port should probably confirm as I am not familiar with the ObjC bindings. The mac ews are green so at least
> >> there is that.
> > 
> > Could someone who understand Objective C bindings confirm that this change is OK please?
> 
> It is fine. We don't generate the ObjC DOM for SVG anymore.

Thanks for looking Timothy.

[Rob Buis]

Comment on attachment 205990 [details]
Patch

Looks good.

[WebKit Commit Bot]

Comment on attachment 205990 [details]
Patch

Clearing flags on attachment: 205990

Committed r152543: <http://trac.webkit.org/changeset/152543>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.