Summary: | [Chromium] .checksum files without .pngs and vice-versa | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mihai Parparita <mihaip> | ||||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | dglazkov, dpranke, joepeck, rniwa, tony | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Mihai Parparita
2011-02-25 11:05:03 PST
Created attachment 83842 [details]
find-mismatched-results.py
Script that I used to find these
I have a script that generates .checksum from .png files, but it's probably not useful. Odds are if there's a png and no checksum, we should delete the png. If there's a checksum and no png, we can probably run the rebaseline script to grab the pngs. If there's a mismatch, we probably want to manually verify the differences. The rebaseline script can still help with this. A pre-submit hook would be useful for catching the missing file cases. Created attachment 83846 [details]
generate checksums from pngs
For reference, here's how to calculate the checksum in python. I think it only works for win/linux since mac does something weird with opacity.
Created attachment 84809 [details]
Patch
(In reply to comment #4) > Created an attachment (id=84809) [details] > Patch May as well get find-mismatched-results.py checked in. This is based on Mihai's code, but I wanted something I could pipe to xargs rm. Comment on attachment 84809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84809&action=review Looks fine otherwise. > Tools/Scripts/find-mismatched-results:51 > + option_parser.error("Please --missing-pngs or --missing-checksums.") Nit. "Please specify either ..." > Tools/Scripts/find-mismatched-results:55 > + '..', '..', 'LayoutTests')] Nit. Should replace this with a webkitpy routine to find the top of the tree. Unfortunately, common.checkout.scm.find_checkout_root() doesn't really do the right thing. layout_tests.port.get().path_from_webkit_base('LayoutTests') should, I think. Maybe add a FIXME? Created attachment 84985 [details]
Patch
Comment on attachment 84985 [details]
Patch
Nit: The name find-mismatched-results is rather generic, maybe find-mismatched-layout-test-results?
Comment on attachment 84985 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84985&action=review > Tools/ChangeLog:5 > + [Chromium] .checksum files without .pngs and vice-versa Nit (if it's not too late): "Find .checksum files ..." ? Committed r80504: <http://trac.webkit.org/changeset/80504> I'm going to go ahead and delete pngs without checksums (all ports) and try grabbing pngs from the bots for checksums without pngs (chromium ports only). We should probably also have a presubmit check for this, but that can be tracked in a different bug. (In reply to comment #11) > I'm going to go ahead and delete pngs without checksums (all ports) and try grabbing pngs from the bots for checksums without pngs (chromium ports only). I deleted pngs without checksums, so `find-mismatched-layout-test-results --missing-checksums` should return nothing now. I was unable to grab pngs from the bots because passing tests don't have archived results. I went ahead and landed pngs for chromium-linux, but most of the missing pngs are in chromium-mac. |