Bug 222467 - Fix clang compilation error in PlatformXR::ViewData initialization
Summary: Fix clang compilation error in PlatformXR::ViewData initialization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebXR (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Imanol Fernandez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-26 05:06 PST by Imanol Fernandez
Modified: 2021-04-19 03:21 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.48 KB, patch)
2021-02-26 05:35 PST, Imanol Fernandez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Imanol Fernandez 2021-02-26 05:06:58 PST
Compilation can fail if the related C99 extension is not supported.

Mixture of designated and non-designated initializers in the same initializer list is a C99 extension [-Wc99-designator]

../../Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:218:24: warning: mixture of designated and non-designated initializers in the same initializer list is a C99 extension [-Wc99-designator]
        views.append({ .active = true, Eye::Right });
                       ^~~~~~~~~~~~~~
../../Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:218:40: note: first non-designated initializer is here
        views.append({ .active = true, Eye::Right });
                                       ^~~~~~~~~~
Comment 1 Imanol Fernandez 2021-02-26 05:35:55 PST
Created attachment 421634 [details]
Patch
Comment 2 Philippe Normand 2021-02-26 05:37:48 PST
Comment on attachment 421634 [details]
Patch

Thanks!
Comment 3 EWS 2021-02-26 06:07:22 PST
Committed r273553: <https://commits.webkit.org/r273553>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421634 [details].
Comment 4 Radar WebKit Bug Importer 2021-02-26 06:08:14 PST
<rdar://problem/74787878>